Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nov način izračuna izidov #293

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Nov način izračuna izidov #293

merged 4 commits into from
Mar 27, 2023

Conversation

matijapretnar
Copy link
Collaborator

Na veliko koncih na strani uporabljamo različne vrste semaforjev, npr.:

  • delež veljavnih/neveljavnih/manjkajočih rešitev vseh podnalog vseh učencev pri danem sklopu
  • delež veljavnih/neveljavnih/manjkajočih rešitev vseh podnalog v predmetu pri danem učencu
  • delež veljavnih/neveljavnih/manjkajočih rešitev vseh učencev pri dani podnalogi
  • delež veljavnih rešitev učenca pri vsakem sklopu
  • ...
    Do sedaj se je vsaka od teh stvari računala na svoj način, zdaj pa se to poenoti z enim razredom Outcome. Zraven sem še optimiziral par stvari.

@matijapretnar matijapretnar requested review from schrjako and k3ap March 24, 2023 05:14
@matijapretnar
Copy link
Collaborator Author

matijapretnar commented Mar 24, 2023

Aja, glavni razlog, da spravim na en način računanja, je #286, saj prehod na problem instance pokvari vsa ta računanja statistike in bi stvari raje popravljal na enem in ne na desetih koncih.

Copy link
Collaborator

@schrjako schrjako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Razen izpostavljenih podrobnosti se mi zdi super dodatek.

schrjako
schrjako previously approved these changes Mar 26, 2023
Copy link
Collaborator

@k3ap k3ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Samo eno vprašanje glede prefetch_related; ostalo izgleda super.

k3ap
k3ap previously approved these changes Mar 26, 2023
@matijapretnar matijapretnar dismissed stale reviews from k3ap and schrjako via 615bd1f March 27, 2023 07:25
@matijapretnar matijapretnar merged commit 82b4f0e into master Mar 27, 2023
@matijapretnar matijapretnar deleted the outcome branch March 27, 2023 07:27
@matijapretnar
Copy link
Collaborator Author

Najlepša hvala obema! Sem še malo počistil commite in dal v master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants