Renames and changing where Payment Comes From #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
payment is set at a host/cluster level now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some modifications to where you specify payment.
Datastore Manifest Removes Payment
It's no longer part of the Datastore Manifest. We realized that once we introduced the idea of there being multiple Argon mainchain instances, you need to ensure payment is coming from whichever deployment the CloudNode or Datastore has targeted. Allowing a Datastore to specify its own payment chain when the cloud node needs to be the one to hook up payments is simply too complex.
Renames
DataDomains were renamed to simply "domains", and Escrows were renamed to Channel Holds. In Ulixee, Channel Holds are used to establish micropayment channels.
Localchain CLI Config
The localchain configs were added to the cloud cli.