Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): improve user agent selector #384

Merged
merged 1 commit into from
Nov 23, 2021
Merged

fix(plugins): improve user agent selector #384

merged 1 commit into from
Nov 23, 2021

Conversation

blakebyrnes
Copy link
Contributor

@blakebyrnes blakebyrnes commented Nov 19, 2021

The user agent selector has a few holes that are plugged by this PR.

  1. The default example in the docs ~mac and chrome >90 did not work
  2. If you had multiple selectors (ie, OS and browser, it would take matches of "either/or", which was not what we wanted)
  3. There are issues if you use an OS we don't know about.
  4. We needed default selectors if you don't provide an operator (=) or version (*)

Closes #369 and causes #371 to emit a better error, but we probably need to follow up with some kind of actual option to use a mobile user agent on a default browser.

@blakebyrnes blakebyrnes linked an issue Nov 19, 2021 that may be closed by this pull request
@calebjclark calebjclark merged commit d28822c into main Nov 23, 2021
@calebjclark calebjclark deleted the useragent branch November 23, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edited: Unable to specify OS without version in "userAgent" field
2 participants