Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Simplify manager to vm provision only #353

Merged
merged 14 commits into from
Jan 20, 2025

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Jan 10, 2025

What type of PR is this?

What does this do?

  • New Features

    • Added support for creating and removing virtual machines via CLI
    • Introduced new gRPC methods for VM management
    • Enhanced CLI with VM-related commands
  • Changes

    • Refactored service architecture to focus on VM management
    • Removed event logging and computation-related functionalities
    • Simplified error handling and SDK initialization processes
  • Removals

    • Eliminated vsock event handling mechanisms
    • Removed computation-specific logging and tracking
    • Discontinued certain middleware and event management components
  • Infrastructure

    • Updated gRPC service definitions
    • Modified client configuration structures
    • Streamlined dependency management

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

to be merged after #350

image

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 17.94872% with 96 lines in your changes missing coverage. Please review.

Project coverage is 62.28%. Comparing base (ecad651) to head (1385a02).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/manager.go 0.00% 44 Missing ⚠️
manager/api/grpc/server.go 0.00% 31 Missing ⚠️
cli/sdk.go 0.00% 16 Missing ⚠️
manager/service.go 72.22% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   65.41%   62.28%   -3.13%     
==========================================
  Files          57       54       -3     
  Lines        4756     4261     -495     
==========================================
- Hits         3111     2654     -457     
+ Misses       1360     1344      -16     
+ Partials      285      263      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
Signed-off-by: Sammy Oina <[email protected]>
@dborovcanin dborovcanin merged commit 1f32f51 into ultravioletrs:main Jan 20, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants