Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to open file dialog #1445

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Make it easier to open file dialog #1445

merged 6 commits into from
Dec 8, 2023

Conversation

yohanboniface
Copy link
Member

Failed attempt to make it easier to open the file dialog for import:

  • tried to add a keyboard shortcut, but it does not work in Firefox (it does in Chrom*, and while it seems it should)
  • tried to focus the field and use autofocus, so once the import panel is open one can press Enter to open the dialog, but it does not work either

As I started working on this, I thought this was the opportunity to move the importer panel to a separate class, as we did for the browser panel.

@yohanboniface yohanboniface marked this pull request as ready for review December 5, 2023 13:05
@yohanboniface yohanboniface merged commit 7ef3fb2 into master Dec 8, 2023
11 checks passed
@yohanboniface yohanboniface deleted the importer-class branch December 8, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants