Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sync): Reconnect the websocket on failures. #2235

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(sync): Reconnect the websocket on failures. #2235

wants to merge 4 commits into from
+189 −40

Commits on Oct 25, 2024

  1. feat(sync): Reconnect the websocket on failures. 

    When the websocket is disconnected, try to redo an authentication
roundtrip. This commit does the following changes:

- Change the way the SyncEngine is instanciated, passing it a server
  object and the urls.
- Add a ping/pong mechanism. This is required because otherwise we have
  no certainty that the connection is still alive.
- Try to reconnect when the connection didn't work out, increasing the
  wait time a bit more each time.
    @almet
    almet committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6643fe0 View commit details
    Browse the repository at this point in the history

  2. feat(sync): Display the state of the connection to the users

    @almet
    almet committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    aac5185 View commit details
    Browse the repository at this point in the history

  3. feat(sync): Display a pannel to the user when disconnected.

    @almet
    almet committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b7ca961 View commit details
    Browse the repository at this point in the history

  4. feat(sync): Check for websocket connectivity and retry if not connected. 

    Because the WebSockets do not offer a way to know when they failed to
connect, use a delay and check the state of the connection.
    @almet
    almet committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    4ba5bbc View commit details
    Browse the repository at this point in the history