cinterface/accarraygen example (Bounded by Generic Package - VHDL 2008) #5

radonnachie · 2020-04-13T14:34:46Z

Examples of sharing dynamically bounded arrays from C to VHDL.

AccArrayInt: an integer is shared from C to VHDL, representing the length of the array. VHDL declares a type array(0 to cInt-1) and that is the bounded array.
AccArrayGen: a generic mapped from the top level entity to the generic package (VHDL 2008) determines the bound of the array.
- This is not working. Currently I am only getting ghdl bugs. Firstly I want make sure that I am using VHDL protected shared accesses correctly before filing a bug.

Addition of example 'accarray', "Access to array". Actually, I'd further split it into 3 different examples:

...

A second one to pass an array, including two possible solutions to using shared variables (-frelaxed or defining a protected type). This should use "easy" types.

radonnachie · 2020-04-13T14:37:43Z

@umarcor Please tell me you will be able to help me learn how to use generic packages and shared protected accesses... I think most of what is there is fine. The ghdl bug printout I get:

bash ./run.sh
Analyze cAccess.vhd and tb.vhd
sem_named_entities: cannot handle IIR_KIND_PROTECTED_TYPE_DECLARATION (cAccess.vhd:11:13)

******************** GHDL Bug occurred ***************************
Please report this bug on https://github.com/ghdl/ghdl/issues
GHDL release: 1.0-dev (v0.37.0-274-g93d01c6d) [Dunoon edition]
Compiled with GNAT Version: 7.5.0
Target: x86_64-linux-gnu
/mnt/d/Development/OpenSource/ghdl-cosim/vhpidirect/cinterface/accarraygen/
Command line:
/etc/ghdl-llvm-PIC/bin/ghdl1-llvm --std=08 -P/etc/ghdl-llvm-PIC/lib/ghdl/ieee/v08/ -P/etc/ghdl-llvm-PIC/lib/ghdl/ -c -fpic -o cAccess.o cAccess.vhd
Exception TYPES.INTERNAL_ERROR raised
Exception information:
raised TYPES.INTERNAL_ERROR : vhdl-errors.adb:32
Call stack traceback locations:
0x4b5e8d 0x56194e 0x562504 0x56b097 0x56b389 0x54aa4f 0x54c2e6 0x5675ce 0x56b028 0x56b389 0x57969f 0x57ab4f 0x532ea4 0x64d4d5 0x64f108 0x650a01 0x4086c9 0x7fc0b90a1b95 0x4079b8 0xffffffff
fffffffe
******************************************************************
ghdl:error: compilation error

umarcor · 2020-04-13T20:38:21Z

@umarcor Please tell me you will be able to help me learn how to use generic packages and shared protected accesses...

I will! Let's solve #4 first. Then, we will discuss naming, .c/.h and style issues. When that is done, it will be easier to dive into this!

radonnachie · 2020-04-15T17:36:22Z

VHDL2008 Generic Package bugs out with VHPIDRECT (ghdl/ghdl/issues/1229)

radonnachie · 2020-04-16T17:45:18Z

ghdl/ghdl/issues/1229 has been resolved, final test will work when git side updates its ghdl. how to?

umarcor · 2020-04-16T19:26:11Z

ghdl/ghdl/issues/1229 has been resolved, final test will work when git side updates its ghdl. how to?

Just wait up to 24h. Then restart the tests, or force push again. Docker images are updated daily: https://github.com/ghdl/docker#-daily-3-jobs--max-3--6-images-daily. There is no triggering mechanism to force them being updated when changes are pushed to ghdl/ghdl.

umarcor · 2020-04-18T20:06:04Z

It seems that you found another legit bug... Is this one of the issues that you already opened in ghdl/ghdl?

radonnachie · 2020-04-19T05:41:55Z

It seems that you found another legit bug

The bug printout above I no longer get. I don't think that the VHDL code was good. I'll checkout that commit and verify if the bug persists.

The current run.sh succeeds on linux but produces a bug on windows. So that may be a legit bug.

******************** GHDL Bug occurred ***************************
Please report this bug on https://github.com/ghdl/ghdl/issues
GHDL release: 0.37 (v0.37) [Dunoon edition]
Compiled with GNAT Version: 9.1.0
Target: x86_64-w64-mingw32
D:\a\ghdl-cosim\ghdl-cosim\vhpidirect\cinterface\accarraygen\
Command line:
D:\a\ghdl-cosim\ghdl\bin\ghdl1-llvm.exe --std=08 -PD:\a\ghdl-cosim\ghdl\lib/ghdl\ieee\v08\ -PD:\a\ghdl-cosim\ghdl\lib/ghdl\ -c -o tb.o tb.vhd
Exception TYPES.INTERNAL_ERROR raised
Exception information:
raised TYPES.INTERNAL_ERROR : vhdl-sem_inst.adb:271
Call stack traceback locations:
0x4f0a03 0x4f18a5 0x4f0993 0x4f18a5 0x4f088a 0x4f284c 0x568545 0x559c60 0x559db9 0x52cd09 0x562b1b 0x569225 0x5240ef 0x635384 0x636fcf 0x6389e5 0x402685 0x40138a 0x4014b9 0x7ffdea127972 0x7ffdeaf4a25f
******************************************************************

radonnachie · 2020-04-19T05:50:47Z

The first bug report I mentioned seems to occur when the protected type has the foreign VHPIDIRECT function in it.

Latest commit the foreign subprog is just in the package, not the protected type.

I have not posted this bug. I'll look to do so. A different cause for it, but ghdl/ghdl/issues/1244 causes the same issue.

umarcor · 2020-04-19T07:04:03Z

The current run.sh succeeds on linux but produces a bug on windows. So that may be a legit bug.

Yes, I meant the one that happens on Windows only.

radonnachie · 2020-04-19T07:44:04Z

It boils down to Generic package having a VHPIDIRECT function. ghdl/ghdl/issues/1229
I'm willing to bet that if I compiled GHDL from master for windows the bug wouldn't come up.
Shall I comment out the test until the GHDL windows realease is incremented?

umarcor · 2020-04-19T08:05:46Z

Shall I comment out the test until the GHDL windows realease is incremented?

Yes, please. Add a comment: #vhpidirect/..., ! fails with v0.37; should work with 'master'.

vhpidirect/cinterface/accarraygen/caux.c

.github/workflows/test.yml

vhpidirect/cinterface/accarraygen/run.sh

vhpidirect/cinterface/accarraygen/tb.vhd

umarcor

Overall, pkg.vhd looks a lot like quickstart/sharedvar/pkg_08.vhd. In fact, it is almost the same, but here the package is a generic package, and the variable is an array instead of an integer.

At the same time caux.c is very similar to quickstart/intvector/vhdlsized/caux.c.

This makes sense, because this new example is a mix between the protected type in quickstart/sharedvar and the vhdlsized vector in intvector.

I think we should make this explicit by using the same files, if possible. At least, by copying the functions/names that are common to the base examples.

BTW, you can use this comment as the base for the (missing) docs of this example.

umarcor · 2020-04-21T22:15:09Z

.github/workflows/test.yml

@@ -75,6 +76,7 @@ jobs:
            vhpidirect/shared/shlib,
            #vhpidirect/shared/dlopen, ! dlfcn.h is not available on win
            #vhpidirect/shared/shghdl, ! dlfcn.h is not available on win
+            #vhpidirect/arrays/invector/vhdlpkgsized, !  fails with v0.37, should work with master (fixed under #1229)


I think it should go below intvector, since it is a subexample. Ideally, we would not add a subexample to the CI list explicitly. Instead, intvector should have a single run.sh that calls other children run.sh if required. However, since we would need to check the host OS in order to do that, I think it's ok to keep it for now.

umarcor · 2020-04-29T19:45:19Z

.github/workflows/test.yml

@@ -75,6 +76,7 @@ jobs:
            vhpidirect/shared/shlib,
            #vhpidirect/shared/dlopen, ! dlfcn.h is not available on win
            #vhpidirect/shared/shghdl, ! dlfcn.h is not available on win
+            #vhpidirect/arrays/intvector/vhdlpkgsized, !  fails with v0.37, should work with master (fixed under #1229)


Maybe this is fixed in the docker image now?

Nope, doesn't look like the windows ghdl has changed.

umarcor · 2020-04-29T20:17:04Z

vhpidirect/arrays/intvector/vhdlpkgsized/main.c

+
+int main(int argc, char const *argv[])
+{
+	int vectorLength = 0;


I feel that +20 lines is too much, since this is not the main feature that we want to show. I think we should accept a single --grow-vec=3 or --grow-vec 3 and multiply it with the size. More complex examples would fit in #14.

I actually really want to move the main.c to #14...
We would do so after this is merged for sure. And it would just take the main.c file and the appropriate half of the run.sh file....

vhpidirect/arrays/intvector/vhdlpkgsized/pkg.vhd

radonnachie · 2020-05-14T07:14:35Z

This makes sense, because this new example is a mix between the protected type in quickstart/sharedvar and the vhdlsized vector in intvector.

sharedvar only references the address of an integer, so the get/set do not take indices, nor is there a free subprog.

If we make a sharedvarIntArr, then we can reuse files.

RocketRoss added 3 commits April 13, 2020 14:05

Add AccArrayInt example: bound by int

c9f688b

Initial accArrayGen: -frelaxed vhdl2008

5f6a240

Expand to shared protected access

0e489f0

radonnachie mentioned this pull request Apr 13, 2020

VHPIDIRECT, HDL_LOGIC_STATE/CHAR, C access example, umarcor/ghdl#1

Closed

9 tasks

move to accarrayint

ec5affb

radonnachie changed the title ~~Acc array examples.~~ AccArray example Apr 14, 2020

radonnachie changed the title ~~AccArray example~~ cinterface/accarraygen example (Bounded by Generic, VHDL 2008) Apr 14, 2020

umarcor force-pushed the master branch from b720397 to 627fd82 Compare April 15, 2020 02:55

Fixed VHDL 2008 AccArrayGen implementation: bugged

bb15bb0

radonnachie changed the title ~~cinterface/accarraygen example (Bounded by Generic, VHDL 2008)~~ cinterface/accarrayint+gen examples (Bounded by Int/Generic w/ VHDL 2008) Apr 15, 2020

Add to tests

a4a09a3

RocketRoss added 4 commits April 15, 2020 19:44

Standardise and clean accarrint

20e340c

Standardize and neaten accarrgen

a3f86ce

Aux.c, pkg, and fix

2b80729

Clean end;s

4359836

umarcor mentioned this pull request Apr 17, 2020

quickstart/logicvector example (Bounded) #6

Closed

radonnachie added 2 commits April 17, 2020 13:36

Merge branch 'master' into accArray

03dd1ba

caux

abe6a7f

radonnachie mentioned this pull request Apr 17, 2020

Add packageless intvector examples (#5 a + c) #11

Open

Remove non-generic version (replaced by umarcor#11)

feab16f

radonnachie added a commit to radonnachie/ghdl-cosim that referenced this pull request Apr 17, 2020

Add packageless intvector generic example (umarcor#5 c)

07efdff

radonnachie mentioned this pull request Apr 17, 2020

Add packageless intvector generic example (#5 c) #12

Closed

Remove int bounded from test

2edd459

Comment out windows test

32e8e37

radonnachie changed the title ~~cinterface/accarrayint+gen examples (Bounded by Int/Generic w/ VHDL 2008)~~ cinterface/accarraygen example (Bounded by Generic Package - VHDL 2008) Apr 20, 2020

umarcor force-pushed the master branch from 2f4925c to 9c06dfd Compare April 21, 2020 11:50

umarcor mentioned this pull request Apr 21, 2020

vhpidirect: add 'arrays' ghdl/ghdl-cosim#18

Merged

umarcor force-pushed the master branch from 65b2c55 to 417ec28 Compare April 21, 2020 13:59

umarcor reviewed Apr 21, 2020

View reviewed changes

vhpidirect/cinterface/accarraygen/caux.c Outdated Show resolved Hide resolved

.github/workflows/test.yml Outdated Show resolved Hide resolved

vhpidirect/cinterface/accarraygen/run.sh Outdated Show resolved Hide resolved

vhpidirect/cinterface/accarraygen/tb.vhd Outdated Show resolved Hide resolved

radonnachie added 7 commits April 21, 2020 21:09

Merge branch 'master' into accArray

3653641

Move/Revise

a912407

Move use tbPkg

be1bdc9

Clean whitespace

d388ee0

Add main() entrypoint with --grow-vec

05c6646

Fix test line

eaef5e1

Grow vec by 2

fb8de69

umarcor reviewed Apr 29, 2020

View reviewed changes

umarcor mentioned this pull request Apr 29, 2020

vhpidirect: add 'arrays/matrices/framebuffer' ghdl/ghdl-cosim#20

Merged

2 tasks

radonnachie added 4 commits May 8, 2020 09:44

ignore extra files

2ad5c38

Merge branch 'master' into accArray

cb512ec

Revision, Minor neatening

cb0f521

Document, reuse vhdlsized caux.c

0c8405a

Keep vhdlpkgsized test separate

7f47917

umarcor mentioned this pull request Jul 14, 2020

quickstart/sharedvar/shrecord example #17

Closed

umarcor force-pushed the master branch from baf8b0c to 9b3842c Compare January 28, 2021 09:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cinterface/accarraygen example (Bounded by Generic Package - VHDL 2008) #5

cinterface/accarraygen example (Bounded by Generic Package - VHDL 2008) #5

radonnachie commented Apr 13, 2020

radonnachie commented Apr 13, 2020

umarcor commented Apr 13, 2020 •

edited

Loading

radonnachie commented Apr 15, 2020

radonnachie commented Apr 16, 2020

umarcor commented Apr 16, 2020

umarcor commented Apr 18, 2020 •

edited

Loading

radonnachie commented Apr 19, 2020

radonnachie commented Apr 19, 2020 •

edited

Loading

umarcor commented Apr 19, 2020

radonnachie commented Apr 19, 2020

umarcor commented Apr 19, 2020

umarcor left a comment

umarcor Apr 21, 2020

umarcor Apr 29, 2020

radonnachie May 14, 2020

umarcor Apr 29, 2020

radonnachie May 14, 2020

radonnachie commented May 14, 2020

cinterface/accarraygen example (Bounded by Generic Package - VHDL 2008) #5

Are you sure you want to change the base?

cinterface/accarraygen example (Bounded by Generic Package - VHDL 2008) #5

Conversation

radonnachie commented Apr 13, 2020

radonnachie commented Apr 13, 2020

umarcor commented Apr 13, 2020 • edited Loading

radonnachie commented Apr 15, 2020

radonnachie commented Apr 16, 2020

umarcor commented Apr 16, 2020

umarcor commented Apr 18, 2020 • edited Loading

radonnachie commented Apr 19, 2020

radonnachie commented Apr 19, 2020 • edited Loading

umarcor commented Apr 19, 2020

radonnachie commented Apr 19, 2020

umarcor commented Apr 19, 2020

umarcor left a comment

Choose a reason for hiding this comment

umarcor Apr 21, 2020

Choose a reason for hiding this comment

umarcor Apr 29, 2020

Choose a reason for hiding this comment

radonnachie May 14, 2020

Choose a reason for hiding this comment

umarcor Apr 29, 2020

Choose a reason for hiding this comment

radonnachie May 14, 2020

Choose a reason for hiding this comment

radonnachie commented May 14, 2020

umarcor commented Apr 13, 2020 •

edited

Loading

umarcor commented Apr 18, 2020 •

edited

Loading

radonnachie commented Apr 19, 2020 •

edited

Loading