-
-
Notifications
You must be signed in to change notification settings - Fork 187
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix tooltips go offscreen and arrowless on mobile
- Fix tooltip overflowing when hovering on script selection options (None, Standard, Strict, All) on UI. This issue was caused because these options had `white-space: nowrap` so they're rendered together. However, as tooltips are rendered inside of the same DOM element with their triggering elements, this style was propagated and caused overflow content to overflow on smaller screens. This commit adds `white-space: initial` on tooltip overlay/container to stop the propogation and fix the issue. - Fix overflow issue revealed another issue with tooltip arrow rendering. When tooltip is shifted from its default position (top) to bottom on smaller screens when there are not enough space on top, the tooltip arrow did not change its position and still stayed on bottom. This was caused because of using wrong reference to get current placement of the tooltip. The issue is fixed by using the reference from `useFloating` function. - Improve `DevToolkit` component to be less intrusive during tests. The DevToolkit is now non-interactable except its buttons for easier testing of tooltips on smaller screens. A new close button is also added on the box, so it can be closed completely if desired.
- Loading branch information
1 parent
47b4823
commit 2cf3a13
Showing
2 changed files
with
89 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters