-
-
Notifications
You must be signed in to change notification settings - Fork 187
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix intermittent
ModalDialog
unit test failures
Refactor `ModalDialog` unit tests to use `shallowMount` consistently. Previously, tests sometimes failed due to the `UseSvgLoader` hook attempting icon loads during component teardown, which occasionally led led to errors when the `window` object became unavailable. By switching to `shallowMount`, tests no longer deeply render child components, mitigating the risk of such errors and aligning with unit testing best practices. Additionally, this commit sets a default value for the `modelValue` prop in test setups to address Vue warnings about missing required props, further stabilizing the test environment.
- Loading branch information
1 parent
b16e136
commit c162397
Showing
1 changed file
with
13 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters