Skip to content

Commit

Permalink
Bump dependencies to latest
Browse files Browse the repository at this point in the history
- Upgrade npm dependencies to their latest
- Upgrade python dependencies to their latest
- Upgrade Node to 22 as 20 is end-of-life since October 2024
  - Refactor `assert` with `with` (see nodejs/node#51622)
- Centralize python setup via custom action for consistency
  • Loading branch information
undergroundwires committed Dec 4, 2024
1 parent 5155f93 commit c6abab3
Show file tree
Hide file tree
Showing 12 changed files with 5,064 additions and 3,593 deletions.
2 changes: 1 addition & 1 deletion .github/actions/setup-node/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ runs:
name: Setup node
uses: actions/setup-node@v4
with:
node-version: 20.x
node-version: 22.x
# check-latest: true # Newest versions can potentially have undiscovered bugs or regressions
8 changes: 8 additions & 0 deletions .github/actions/setup-python/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
runs:
using: composite
steps:
-
name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.13'
12 changes: 4 additions & 8 deletions .github/workflows/checks.quality.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,8 @@ jobs:
name: Setup node
uses: ./.github/actions/setup-node
-
name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.x'
name: Setup node
uses: ./.github/actions/setup-python
-
name: Install dependencies
run: |
Expand All @@ -90,10 +88,8 @@ jobs:
name: Setup node
uses: ./.github/actions/setup-node
-
name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.x'
name: Setup node
uses: ./.github/actions/setup-python
-
name: Install dependencies
run: python3 -m pip install -r ./scripts/validate-collections-yaml/requirements.txt
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/checks.scripts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,8 @@ jobs:
name: Checkout
uses: actions/checkout@v4
-
name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.x'
name: Setup node
uses: ./.github/actions/setup-python
-
name: Install VSCode
run: ${{ matrix.os.install-vscode-command }}
Expand Down
2 changes: 1 addition & 1 deletion cypress.config.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { defineConfig } from 'cypress';
import ViteConfig from './vite.config';
import cypressDirs from './cypress-dirs.json' assert { type: 'json' };
import cypressDirs from './cypress-dirs.json' with { type: 'json' };

export default defineConfig({
fixturesFolder: `${cypressDirs.base}/fixtures`,
Expand Down
2 changes: 1 addition & 1 deletion electron.vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { mergeConfig, type UserConfig } from 'vite';
import { defineConfig, externalizeDepsPlugin } from 'electron-vite';
import { getAliases, getClientEnvironmentVariables } from './vite-config-helper';
import { createVueConfig } from './vite.config';
import distDirs from './dist-dirs.json' assert { type: 'json' };
import distDirs from './dist-dirs.json' with { type: 'json' };

const MAIN_ENTRY_FILE = resolvePathFromProjectRoot('src/presentation/electron/main/index.ts');
const PRELOAD_ENTRY_FILE = resolvePathFromProjectRoot('src/presentation/electron/preload/index.ts');
Expand Down
Loading

0 comments on commit c6abab3

Please sign in to comment.