Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize urls with trailing slashes #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WayneMorganUK
Copy link

On deployment to netlify I noticed that all the urls had trailing slashes. This resulted in an issue with the styling of active items on the navbar on pages other than root. This was not an issue in npm run dev nor npm run preview but only on deployment.
By adding a trailing slash to the anchor tags resolved the lack of styling

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
astro-beginner-project ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 2:34pm

@WayneMorganUK WayneMorganUK marked this pull request as ready for review June 6, 2023 14:35
@ohansemmanuel
Copy link
Contributor

Thanks, @WayneMorganUK - do you mind using the existing package manager? i.e., npm ? This will remove the need for the pnpm lock file.

Cheers, and thanks for spotting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants