predict tutorial #219
Merged
predict tutorial #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
behinger
commented
Sep 26, 2024
behinger
commented
- up predict.jl
- add assert
- Update src/predict.jl
- Update src/predict.jl
- rename variable
- Update src/predict.jl
- update assert in predict.jl
- minor predict improvements
update predict function for partial overlap, so that keep_basis input is converted to vector.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rename variable to be Julia standard compliant
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ReneSkukies
approved these changes
Sep 26, 2024
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
Co-authored-by: René Skukies <[email protected]>
|
nice thanks! I think if you do a "review" next time, I could accept all of them at once; but I'm not sure - aybe you even did that :) edit: will wait for the CI and then merge |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # In the plot, we see the two partial predictions for car and face. They are respectively "0" outside the basisfunction windows | ||
|
|
||
| # !!! note | ||
| # The above options can be combined as well, e.g. to get an `epoch_to`, `exclude_basis` version. `epoch_timewindow` can be specified as well. |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # The above options can be combined as well, e.g. to get an `epoch_to`, `exclude_basis` version. `epoch_timewindow` can be specified as well. | |
| # The above options can be combined as well, e.g. to get an `epoch_to`, `exclude_basis` version. `epoch_timewindow` can be specified as well. |
That is indeed what I did :') |
|
Damn alright - very annoying I had to accept each commit on its own. Maybe I didn't see it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.