Skip to content

Commit

Permalink
Add ignoreJava annotations for tests with runtime errors
Browse files Browse the repository at this point in the history
  • Loading branch information
@catamorphism
catamorphism committed Aug 8, 2024
1 parent 696755f commit 1555928
Show file tree
Hide file tree
Showing 6 changed files with 61 additions and 32 deletions.
8 changes: 5 additions & 3 deletions testdata/message2/spec/functions/date.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "The built-in formatter for dates.",
"defaultTestProperties": {
"locale": "en-US",
"expErrors": false
"expErrors": []
},
"tests": [
{
Expand All @@ -13,7 +13,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "{horse :date}",
Expand All @@ -38,7 +39,8 @@
"src": ".local $d = {|2006-01-02| :date style=long} {{{$d :date}}}"
},
{
"src": ".local $t = {|2006-01-02T15:04:06| :time} {{{$t :date}}}"
"src": ".local $t = {|2006-01-02T15:04:06| :time} {{{$t :date}}}",
"ignoreJava": "ICU4J doesn't support this kind of composition"
}
]
}
11 changes: 7 additions & 4 deletions testdata/message2/spec/functions/datetime.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "The built-in formatter for datetimes.",
"defaultTestProperties": {
"locale": "en-US",
"expErrors": false
"expErrors": []
},
"tests": [
{
Expand All @@ -13,7 +13,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "{$x :datetime}",
Expand All @@ -28,7 +29,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "{horse :datetime}",
Expand All @@ -37,7 +39,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "{|2006-01-02T15:04:06| :datetime}"
Expand Down
36 changes: 24 additions & 12 deletions testdata/message2/spec/functions/number.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "invalid number literal {|.1| :number}",
Expand All @@ -33,7 +34,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "invalid number literal {|1.| :number}",
Expand All @@ -42,7 +44,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "invalid number literal {|01| :number}",
Expand All @@ -51,7 +54,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "invalid number literal {|+1| :number}",
Expand All @@ -60,7 +64,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "invalid number literal {|0x1| :number}",
Expand All @@ -69,7 +74,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "hello {:number}",
Expand All @@ -78,7 +84,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "hello {4.2 :number minimumFractionDigits=2}",
Expand Down Expand Up @@ -141,7 +148,8 @@
{
"type": "bad-option"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": ".local $foo = {$bar :number} {{bar {$foo}}}",
Expand All @@ -156,7 +164,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": ".input {$foo :number} {{bar {$foo}}}",
Expand Down Expand Up @@ -191,7 +200,8 @@
{
"type": "bad-option"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": ".input {$foo :number} {{bar {$foo}}}",
Expand All @@ -206,7 +216,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": ".match {$foo :number} one {{one}} * {{other}}",
Expand Down Expand Up @@ -373,7 +384,8 @@
{
"type": "unresolved-variable"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "{42 :number @foo @bar=13}",
Expand Down
6 changes: 4 additions & 2 deletions testdata/message2/spec/functions/string.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
"value": 1
}
],
"exp": "one"
"exp": "one",
"ignoreJava": ":string doesn't stringify numbers?"
},
{
"src": ".match {$foo :string} 1 {{one}} * {{other}}",
Expand All @@ -43,7 +44,8 @@
{
"type": "unresolved-variable"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
}
]
}
11 changes: 7 additions & 4 deletions testdata/message2/spec/functions/time.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "The built-in formatter for times.",
"defaultTestProperties": {
"locale": "en-US",
"expErrors": false
"expErrors": []
},
"tests": [
{
Expand All @@ -13,7 +13,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "{horse :time}",
Expand All @@ -22,7 +23,8 @@
{
"type": "bad-operand"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "{|2006-01-02T15:04:06| :time}"
Expand All @@ -34,7 +36,8 @@
"src": ".local $t = {|2006-01-02T15:04:06| :time style=medium} {{{$t :time}}}"
},
{
"src": ".local $d = {|2006-01-02T15:04:06| :date} {{{$d :time}}}"
"src": ".local $d = {|2006-01-02T15:04:06| :date} {{{$d :time}}}",
"ignoreJava": "ICU4J doesn't support this kind of composition"
}
]
}
21 changes: 14 additions & 7 deletions testdata/message2/spec/test-core.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
"type": "unresolved-variable"
}
],
"exp": "hello {$place}"
"exp": "hello {$place}",
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "{$one} and {$two}",
Expand Down Expand Up @@ -325,7 +326,8 @@
{
"type": "unsupported-expression"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "foo {&private}",
Expand All @@ -344,7 +346,8 @@
{
"type": "unsupported-expression"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "foo {?reserved @a @b=$c}",
Expand All @@ -363,7 +366,8 @@
{
"type": "unsupported-expression"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": ".foo {42} {{bar}}",
Expand All @@ -378,7 +382,8 @@
{
"type": "unsupported-statement"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": ".foo{42}{{bar}}",
Expand All @@ -394,7 +399,8 @@
{
"type": "unsupported-statement"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": ".foo |}lit{| {42}{{bar}}",
Expand All @@ -410,7 +416,8 @@
{
"type": "unsupported-statement"
}
]
],
"ignoreJava": "See https://github.com/unicode-org/message-format-wg/issues/782"
},
{
"src": "{{trailing whitespace}} \n",
Expand Down

0 comments on commit 1555928

Please sign in to comment.