fix warning

unicode-org · Jan 21, 2025 · c2e68d5 · c2e68d5
1 parent 7c30dff
commit c2e68d5
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/icu4c/source/i18n/measunit_extra.cpp b/icu4c/source/i18n/measunit_extra.cpp
@@ -553,7 +553,7 @@ class Token {
     // If the value is not positive integer, it will return `kUnitIdentifierSyntaxError`.
     uint64_t parseStrigToLong(const StringPiece str, UErrorCode &status) {
         uint64_t result = 0;
-        int64_t max_int64 = ~((int64_t)1 << 63);
+        uint64_t max_int64 = ~((int64_t)1 << 63); // the maximum number of int64_t
 
         // Check for empty string
         if (str.empty()) {
@@ -636,7 +636,7 @@ class Token {
         }
 
         // Apply the exponent
-        for (size_t i = 0; i < exponent; ++i) {
+        for (int32_t i = 0; i < exponent; ++i) {
             result *= 10;
 
             if (result > max_int64) {
@@ -645,6 +645,11 @@ class Token {
             }
         }
 
+        if (result == 0) {
+            status = kUnitIdentifierSyntaxError;
+            return result; // add it for code consistency.
+        }
+
         return result;
     }
 
@@ -745,9 +750,7 @@ class Parser {
             }
 
             U_ASSERT(singleUnitOrConstant.isSingleUnit());
-            SingleUnitImpl singleUnit = singleUnitOrConstant.getSingleUnit();
-
-            bool added = result.appendSingleUnit(singleUnitOrConstant.singleUnit, status);
+            bool added = result.appendSingleUnit(singleUnitOrConstant.getSingleUnit(), status);
             if (U_FAILURE(status)) {
                 return result;
             }