Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22314 Refactor GH CI jobs into workflows triggered by modified paths #2700

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Nov 14, 2023

Testing PRs in personal fork:

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22314
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@echeran echeran marked this pull request as ready for review November 17, 2023 22:02
mihnita
mihnita previously approved these changes Nov 18, 2023
Copy link
Contributor

@mihnita mihnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@mihnita
Copy link
Contributor

mihnita commented Nov 18, 2023

Hmm, I wonder if there is something to cover the "transition" between icu4c and icu4j.
When we generate binary resources (.res & co) from C to Java, there are new files in icu4j, so that's OK.
But do we test the stuff in /tools (the root one, not icu4j/tools)
It looks like we don't test that now (before this PR)

(the LGTM / approve still stands, as this is something we don't do today)

markusicu
markusicu previously approved these changes Nov 29, 2023
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for two nits/questions

.github/workflows/icu_common.yml Show resolved Hide resolved
.github/workflows/icu_docs.yml Outdated Show resolved Hide resolved
@echeran echeran dismissed stale reviews from markusicu and mihnita via 7221c6c November 29, 2023 22:09
@echeran echeran force-pushed the ci-job-by-code-type branch from 2d92756 to 7221c6c Compare November 29, 2023 22:09
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/icu_common.yml is different
  • .github/workflows/icu_docs.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran echeran merged commit 2adf957 into unicode-org:main Nov 29, 2023
31 checks passed
@echeran echeran deleted the ci-job-by-code-type branch November 29, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants