Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22589 Avoid timeout in TimeZone test #2718

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Dec 4, 2023

The bug was filed because the fuzzer test data is very large and take a long time to run. Not an infinity loop. This PR limit the data to at most 2000 bytes so it will complete in reasonable amount of time.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22589
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@FrankYFTang FrankYFTang merged commit 2a3cb99 into unicode-org:main Dec 6, 2023
94 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22589-timeout_timezone_create_fuzzer branch December 6, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants