Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22580 Address infinity loop in RBBI #2735

Merged
merged 1 commit into from
Dec 11, 2023
Merged

ICU-22580 Address infinity loop in RBBI #2735

merged 1 commit into from
Dec 11, 2023

Conversation

FrankYFTang
Copy link
Contributor

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22580
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

aheninger
aheninger requested changes Dec 9, 2023
View reviewed changes
icu4c/source/test/intltest/rbbiapts.cpp Outdated
}
for (char16_t u2 = u' '; u2 <= u'~'; u2++) {
{
UnicodeString rule = {u1, u2, 0};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not doing what you think. It's invoking some three-argument constructor on UnicodeString, the result of which is an empty string.

Do something like this instead:
UnicodeString rule; rule.append(u1); rule.append(u2)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE. PTAL

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/rbbiscan.cpp is different
  • icu4c/source/test/intltest/rbbiapts.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang
Copy link
Contributor Author

PTAL

@FrankYFTang FrankYFTang merged commit 4da7ffa into unicode-org:main Dec 11, 2023
102 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22580-OOO branch December 11, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aheninger aheninger aheninger approved these changes

@richgillam richgillam Awaiting requested review from richgillam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYFTang @aheninger