Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22727 Fix uloc_addLikelySubtags for alpha{5,8} unicode_language_subtag #2958

Merged
merged 1 commit into from
Apr 11, 2024
Merged

ICU-22727 Fix uloc_addLikelySubtags for alpha{5,8} unicode_language_subtag #2958

merged 1 commit into from
Apr 11, 2024

Conversation

FrankYFTang
Copy link
Contributor

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22727
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang FrankYFTang requested a review from markusicu April 11, 2024 18:28
@FrankYFTang
ICU-22727 fix addLikelySubtags for 5-8 chars lang codes
cf5fc74 
Fix C++ code, add tests for C, C++ and Java API
@FrankYFTang FrankYFTang force-pushed the ICU-22727-5-8-likelySubtag-maint75 branch from 01b140e to cf5fc74 Compare April 11, 2024 18:36
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@FrankYFTang FrankYFTang merged commit 6d4cea5 into unicode-org:maint/maint-75 Apr 11, 2024
103 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22727-5-8-likelySubtag-maint75 branch April 11, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYFTang @markusicu