Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22718 backport Export disallowed/ignored UTS 46 data for ICU4X #3009

Merged
merged 1 commit into from
May 16, 2024
Merged

ICU-22718 backport Export disallowed/ignored UTS 46 data for ICU4X #3009

merged 1 commit into from
May 16, 2024

Conversation

hsivonen
Copy link
Member

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22718
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

This was referenced May 15, 2024
Merged
Closed
@markusicu
Copy link
Member

Hi @roubert I see the MSYS CI check failing here. Can you please cherry-pick your fix for that to the maint/maint-75 branch?

@markusicu markusicu self-assigned this May 15, 2024
@robertbastian robertbastian removed their request for review May 15, 2024 19:11
sffc
sffc approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a clean pick of 3988908

@roubert
Copy link
Member

roubert commented May 16, 2024

Hi @roubert I see the MSYS CI check failing here. Can you please cherry-pick your fix for that to the maint/maint-75 branch?

PR #3011

@markusicu
Copy link
Member

Hi @roubert I see the MSYS CI check failing here. Can you please cherry-pick your fix for that to the maint/maint-75 branch?

PR #3011

... and merged. @hsivonen please rebase past that.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@hsivonen
Copy link
Member Author

Rebased.

@sffc sffc merged commit b8389b1 into unicode-org:maint/maint-75 May 16, 2024
97 checks passed
@sffc sffc mentioned this pull request May 16, 2024
Merged
robertbastian added a commit to unicode-org/icu4x that referenced this pull request May 17, 2024
@sffc @robertbastian
Update ICU tag to icu4x/2024-05-16/75.x (#4913)
462feb4 
Integrates unicode-org/icu#3009

---------

Co-authored-by: Robert Bastian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@echeran echeran Awaiting requested review from echeran

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsivonen @markusicu @roubert @sffc