Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22696 Update ulocimp_to*{Key,Type}() to use std::string_view #3073

Merged
merged 1 commit into from
Aug 7, 2024
Merged

ICU-22696 Update ulocimp_to*{Key,Type}() to use std::string_view #3073

merged 1 commit into from
Aug 7, 2024

Conversation

roubert
Copy link
Member

@roubert roubert commented Jul 31, 2024

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22696
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@roubert roubert marked this pull request as draft July 31, 2024 15:23
@roubert roubert marked this pull request as ready for review August 5, 2024 20:16
@roubert roubert requested a review from markusicu August 5, 2024 20:16
@roubert roubert merged commit 8a6d59e into unicode-org:main Aug 7, 2024
99 checks passed
@roubert roubert deleted the 22696-key-type branch August 7, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roubert @markusicu