ICU-22819 Fix memory leak during error in mlbe.cpp #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYFTang
changed the title
aheninger
reviewed
Aug 2, 2024
icu4c/source/common/mlbe.cpp
Outdated
| if (idx + 4 < codePointLength) { | ||
| indexList[idx + 6] = numCodeUnits; | ||
| numCodeUnits += U16_LENGTH(inString.char32At(indexList[idx + 6])); | ||
| } | ||
| } | ||
| } | ||
| uprv_free(indexList); |
There was a problem hiding this comment.
You could change indexList to be a LocalMemory<int32_t>. Get rid of the error prone naked pointer and explicit free() altogether.
FrankYFTang
force-pushed
the
ICU-22819-mlbeMemoryLeak
branch
from
5cbd66f to
61fa9cf
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
aheninger
approved these changes
Aug 2, 2024
richgillam
approved these changes
Aug 2, 2024
icu4c/source/common/mlbe.cpp
Outdated
| if (idx + 4 < codePointLength) { | ||
| indexList[idx + 6] = numCodeUnits; | ||
| numCodeUnits += U16_LENGTH(inString.char32At(indexList[idx + 6])); | ||
| } | ||
| } | ||
| } | ||
| uprv_free(indexList); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist