Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22830 Fix memLeak in numrange_fluent.cpp #3085

Merged
merged 1 commit into from
Aug 6, 2024
Merged

ICU-22830 Fix memLeak in numrange_fluent.cpp #3085

merged 1 commit into from
Aug 6, 2024

Conversation

FrankYFTang
Copy link
Contributor

Maybe related to the leak in ICU-22800

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22830
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang
ICU-22830 Fix memLeak in numrange_fluent.cpp
c8624bc 
Maybe related to the leak in ICU-22800
@FrankYFTang FrankYFTang force-pushed the ICU-22830-MemLeak-numrange_fluent branch from 1b6d37d to c8624bc Compare August 5, 2024 23:22
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/i18n/numrange_fluent.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

richgillam
richgillam approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks a lot nicer, actually.

@FrankYFTang FrankYFTang merged commit 09ae314 into unicode-org:main Aug 6, 2024
99 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22830-MemLeak-numrange_fluent branch August 6, 2024 02:30
@roubert roubert removed their request for review August 6, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richgillam richgillam richgillam approved these changes

@sffc sffc Awaiting requested review from sffc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYFTang @richgillam