Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22831 Fix memLeak in number_longnames.cpp by using LocalPointer #3086

Merged

Conversation

FrankYFTang
Copy link
Contributor

Maybe fix issues in ICU-22800

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22831
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@FrankYFTang FrankYFTang merged commit 575bb78 into unicode-org:main Aug 6, 2024
99 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22831-number_longnames branch August 6, 2024 02:28
@roubert roubert removed their request for review August 6, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants