Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22874 Update ICU4C to use a current version of the autotools #3169

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

roubert
Copy link
Member

@roubert roubert commented Sep 16, 2024

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22874
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

@roubert roubert marked this pull request as ready for review September 16, 2024 12:52
@roubert roubert requested a review from srl295 September 16, 2024 12:52
icu4c/source/configure.ac Show resolved Hide resolved
@roubert roubert merged commit 688957e into unicode-org:main Sep 16, 2024
101 checks passed
@roubert roubert deleted the 22874 branch September 16, 2024 14:12
@markusicu
Copy link
Member

Thank you!
@roubert or @srl295 do we need to update the relevant LICENSE file sections for this new version?
https://github.com/unicode-org/icu/blob/main/LICENSE#L464-L525

@yumaoka FYI

@roubert
Copy link
Member Author

roubert commented Sep 17, 2024

@roubert or @srl295 do we need to update the relevant LICENSE file sections for this new version?

I can't imagine why that would be necessary (but on the other hand, I'm generally not very good at imagining such stuff).

@markusicu
Copy link
Member

@roubert or @srl295 do we need to update the relevant LICENSE file sections for this new version?

I can't imagine why that would be necessary (but on the other hand, I'm generally not very good at imagining such stuff).

Well, the license texts should be in sync between files that have special license and our collective LICENSE file.

I just checked, and only one character changed in the license text in one of these files

@roubert
Copy link
Member Author

roubert commented Sep 19, 2024

I just checked, and only one character changed in the license text in one of these files

OK, changing that semicolon to a comma is definitely something that I could never have imagined that it would matter,

@markusicu
Copy link
Member

It probably doesn't matter, but it's good to be in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants