Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22921 Document a way to remove unused includes from command line #3298

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Dec 10, 2024

Checklist

  • Required: Issue filed: ICU-22921
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@mihnita mihnita requested review from yumaoka and markusicu December 10, 2024 22:02
@mihnita mihnita force-pushed the mihai_clean_imports branch from 9468239 to 230e0ab Compare December 10, 2024 22:28
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/processes/release/tasks/healthy-code.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/processes/release/tasks/healthy-code.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • PR title & commit message are for CLDR-17742 “DDL: Improve documentation” ... for an ICU change
  • PR description says ICU-17742 which is "an empty ticket"
  • You probably wanted to use ICU-22921 ?

docs/processes/release/tasks/healthy-code.md Outdated Show resolved Hide resolved
@mihnita mihnita changed the title CLDR-17742 Document a way to remove unused includes from command line ICU-22921 Document a way to remove unused includes from command line Dec 12, 2024
@mihnita mihnita requested a review from markusicu December 12, 2024 19:28
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the ticket when you squash

@mihnita mihnita force-pushed the mihai_clean_imports branch from fc77766 to d1e9c9e Compare December 12, 2024 19:45
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita mihnita merged commit 0295105 into unicode-org:main Dec 12, 2024
9 checks passed
@mihnita mihnita deleted the mihai_clean_imports branch December 12, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants