Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-23018 Add unit conversion API with comprehensive tests (Java) #3345

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

younies
Copy link
Member

@younies younies commented Jan 24, 2025

Description:

  • Introduced UnitsConverter, CompoundUnitsConverter, and related classes to facilitate unit conversions.
  • Implemented a new test suite in UnitsConverterTest to validate conversion accuracy across various units, including length, speed, and temperature.
  • Enhanced UnitsConverter with cloning capabilities.
  • Added builder pattern support for CompoundUnitsConverter to streamline the conversion process.

Checklist

  • Required: Issue filed: ICU-23018
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

- Introduced `UnitsConverter`, `CompoundUnitsConverter`, and related classes to facilitate unit conversions.
- Implemented a new test suite in `UnitsConverterTest` to validate conversion accuracy across various units, including length, speed, and temperature.
- Enhanced `UnitsConverter` with cloning capabilities and improved constructor for better initialization.
- Added builder pattern support for `CompoundUnitsConverter` to streamline the conversion process.

This commit lays the groundwork for robust unit conversion features in the ICU library.
- Added copyright notices for Unicode, Inc. and IBM to the top of the UnitsConverterTest.java file.
@younies younies marked this pull request as draft January 24, 2025 21:34
@younies younies changed the title ICU-23018 Add unit conversion functionality with comprehensive tests ICU-23018 Add unit conversion API with comprehensive tests (Java) Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant