Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22781 Add support for converting units with constant denominators (Java) #3346

Merged
merged 1 commit into from
Jan 24, 2025
Merged

ICU-22781 Add support for converting units with constant denominators (Java) #3346

merged 1 commit into from
Jan 24, 2025

Conversation

younies
Copy link
Member

@younies younies commented Jan 24, 2025 •
edited
Loading

Description:

Implement handling of constant denominators in unit conversion:

  • Add divide method to Factor class in UnitsConverter
  • Update ConversionRates to apply constant denominator during conversion
  • Add comprehensive test cases for units with constant denominators

Checklist

  • Required: Issue filed: ICU-NNNNN
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@younies
ICU-22781 Add support for constant denominators in unit conversion
747dd4c 
Implement handling of constant denominators in unit conversion:
- Add divide method to Factor class in UnitsConverter
- Update ConversionRates to apply constant denominator during conversion
- Add comprehensive test cases for units with constant denominators
@younies younies requested review from sffc and richgillam January 24, 2025 23:29
richgillam
richgillam approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@younies younies merged commit 4df4eb4 into unicode-org:main Jan 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richgillam richgillam richgillam approved these changes

@sffc sffc Awaiting requested review from sffc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@younies @richgillam