-
-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22922 CLDR 47 alpha1 to main #3356
ICU-22922 CLDR 47 alpha1 to main #3356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data file changes are practially unreviewable. I am ok rubber-stamping them, but it would be better to first do a null integration of the same data as in the last integration, but with the tool change and with CLDR version number 47. Easy to rubber-stamp. Then integrating actual 47 alpha would be limited to the real changes.
And if real data changes exceed 1000 files (or maybe an even lower threshold), please split them into multiple commits.
fi{ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we getting an empty Finnish brkitr file? Is there a new empty Finnish CLDR file?
Same question for sv=Swedish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. We no longer have fi or sv entries in icu4c/source/data/xml/brkitr/*.xml which was my first guess at why these might be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Progress figuring this out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My best guess is that fi or sv entries in icu4c/source/data/xml/brkitr/*.xml got removed, but they are still somewhere in some list for building .txt files from that repo. I will look at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I have a chance today I will also try do an integration to investigate this...
But I see that in CLDR, common/segmentation/ still has word break tailorings for fi
and sv
. Perhaps these need to be removed; even thought the contents of the tailorings are not converted for ICU, the presence of the files may affect ICU. This probably needs to be discussed with Mark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fi/sv wordbreak tailorings were removed in ICU in October 2024 per ICU-22941 for ICU 77, so this is the first integration of CLDR for ICU 77. Those word break tailorings were added in CLDR in Aug 2022 per CLDR-15910 for CLDR 42. Need to file a CLDR ticket to remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will ignore for this integration, address in CLDR for next integration
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/util/LocaleMatcherTest.java
Outdated
Show resolved
Hide resolved
Oh, and please remember to clean up the PR description. |
Cleaned up. |
Checklist
Alpha1 integration for CLDR 47.
Includes updates for tzdata to 2024b and adding new measurement units (duration-night and light-speed).
Changes in unit tests
Known issues:
ALLOW_MANY_COMMITS=true