Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22781 Fix &Improve MeasureUnit identifier generation for constant denominators (C++) #3364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ICU-22781 Fix &Improve MeasureUnit identifier generation for constant denominators (C++) #3364

wants to merge 1 commit into from
+88 −6

Conversation

younies
Copy link
Member

@younies younies commented Feb 3, 2025

Description

  • Add support for generating more compact identifiers for constant denominators
  • Introduce methods to convert large constant denominators to scientific notation
  • Update MeasureUnitImpl to use new constant denominator string generation
  • Add test cases to verify identifier generation for various constant denominator scenarios

Checklist

  • Required: Issue filed: ICU-22781
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@younies younies force-pushed the cpp-get-identifier branch from 106fc02 to a4c190a Compare February 3, 2025 14:07
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@younies younies requested review from sffc and richgillam February 3, 2025 14:07
richgillam
richgillam approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOKTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richgillam richgillam richgillam approved these changes

@sffc sffc Awaiting requested review from sffc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@younies @richgillam