-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterate through canonical timezones and metazones #5675
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -95,6 +95,8 @@ pub struct IanaToBcp47MapV3<'data> { | |
// Note: this is 9739B as `ZeroVec<TimeZoneBcp47Id>` (`ZeroVec<TinyStr8>`) | ||
// and 9335B as `VarZeroVec<str>` | ||
pub bcp47_ids: ZeroVec<'data, TimeZoneBcp47Id>, | ||
/// Metazones | ||
pub metazones: ZeroVec<'data, u16>, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Issue: Please explain/document this field. Previous authors of this data struct (mostly me) have gone above and beyond documenting how the pieces fit together, since it is non-obvious. I don't immediately see how a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Issue: Besides iterating over metazones, what do you plan to use this field for? (We shouldn't add fields to the core TimeZoneIdMapper data struct unless they have a strong core use case) |
||
/// An XxHash64 checksum of [`Self::bcp47_ids`]. | ||
pub bcp47_ids_checksum: u64, | ||
} | ||
|
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
time_zone/bcp47_to_iana@1, <singleton>, 7643B, 7623B, d999c8ca67868c35 | ||
time_zone/iana_to_bcp47@3, <singleton>, 9579B, 9538B, 1bf6347ae2f6619d | ||
time_zone/iana_to_bcp47@3, <singleton>, 9921B, 9858B, 192398d2ca5e487 | ||
time_zone/metazone_period@1, <singleton>, 11097B, 11009B, dcfa50fb39ebd549 | ||
time_zone/offset_period@1, <singleton>, 13374B, 13286B, 397b18d3f2345411 | ||
time_zone/windows_zones_to_bcp47@1, <singleton>, 8634B, 8591B, 90b7fe3f9cadf5bd |
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: huh? The function returns an iterator of
TimeZoneBcp47Id
but it is documented as returning an iterator of metazones.