Merge pull request xyflow#4874 from crimx/patch-1

fix(system): safely handles non-html-element object
unifygtm · Dec 9, 2024 · 90d4726 · 90d4726
2 parents 21b7e95 + d60331e
commit 90d4726
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/brown-pugs-pump.md b/.changeset/brown-pugs-pump.md
@@ -0,0 +1,5 @@
+---
+'@xyflow/system': patch
+---
+
+Refactor isInputDOMNode so that it handles non-html objects
diff --git a/packages/system/src/utils/dom.ts b/packages/system/src/utils/dom.ts
@@ -40,7 +40,7 @@ const inputTags = ['INPUT', 'SELECT', 'TEXTAREA'];
 export function isInputDOMNode(event: KeyboardEvent): boolean {
   // using composed path for handling shadow dom
   const target = (event.composedPath?.()?.[0] || event.target) as HTMLElement;
-  const isInput = inputTags.includes(target?.nodeName) || target?.hasAttribute('contenteditable');
+  const isInput = inputTags.includes(target?.nodeName) || target?.hasAttribute?.('contenteditable');
 
   // when an input field is focused we don't want to trigger deletion or movement of nodes
   return isInput || !!target?.closest('.nokey');