Introduce ELF binfmt loader #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michpappas
force-pushed
the
michpappas/feature/binfmt_elf
branch
from
9db9fca
to
bf8b46c
Compare
4 tasks
mogasergiu
requested changes
Jul 28, 2024
POSIX defines the minimum total size of argv + envp to ARG_MAX, and leaves the inclusion of NULL terminators, pointers and / or alignment bytes as implementation defined. The policy we implement is: - Permit the total length to exceed ARG_MAX as long as it's not greater than 1/4 of the stack size. This is essentially the same policy as linux (see execve(2)), with the difference that we don't apply the MAX_ARG_STRLEN floor of 32 pages. - Exclude auxv, NULL, andlignment bytes from the checked size, as these are of fixed size and occupy an insignificant portion of the stack. Signed-off-by: Michalis Pappas <[email protected]>
michpappas
force-pushed
the
michpappas/feature/binfmt_elf
branch
from
bf8b46c
to
41d6132
Compare
mogasergiu
reviewed
Jul 30, 2024
Add binfmt loader for ELF. This is the default loader used on execve(). Signed-off-by: Michalis Pappas <[email protected]>
michpappas
force-pushed
the
michpappas/feature/binfmt_elf
branch
from
41d6132
to
9ad500d
Compare
mogasergiu
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unikraft/unikraft#1386 implements
execve()via the newly introducedlibukbinfmt, which allows the registration of loaders of different binary file formats. This PR introduces the ELF binfmt loader, which is used internally byexecve().GitHub-Depends-On: #73
GitHub-Depends-On: #77