Handle empty file size loadable segments #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases such as those if the application has no .data but has .bss, the .bss may end up being alone in an empty filesz loadable segment. Handle such situation by only `mmap`ing file contents if the segment has actual file contents (filesz != 0). Signed-off-by: Sergiu Moga <[email protected]>
Mihnea0Firoiu
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
All good, thanks!
Reviewed-by: Mihnea Firoiu [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases such as those if the application has no .data but has .bss, the .bss may end up being alone in an empty filesz loadable segment. Handle such situation by only
mmaping file contents if the segment has actual file contents (filesz != 0).