utils: Add new design for generator script #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Razvan Deaconescu <[email protected]>
RaduNichita
reviewed
Jun 20, 2024
utils/new-design/all.py
Outdated
| 'networking': i[8] | ||
| } | ||
|
|
||
| def _is_valid_config(d): |
There was a problem hiding this comment.
Can we keep an order about the if clauses?
For example - platform, then hypervisor, then netowrking and so on?
utils/new-design/all.py
Outdated
| } | ||
| libs = [] | ||
| targets = [] | ||
| scripts_dir = os.path.join(os.getcwd(), "scripts") |
There was a problem hiding this comment.
Suggested change
| scripts_dir = os.path.join(os.getcwd(), "scripts") | |
| scripts_dir = os.path.join(os.getcwd(), SCRIPTS_PATH) |
I think it may be better if we want to change the path in the future?
utils/new-design/all.py
Outdated
| import itertools | ||
|
|
||
| class ConfigVariants: | ||
| arch = ['arm64', 'x86_64'] |
There was a problem hiding this comment.
Suggested change
| arch = ['arm64', 'x86_64'] | |
| arch = ['arm64', 'x86_64'] |
I think it would be better to have a dictionary here to keep track a number of options (an option means arch, hypervisor, platform etc)
utils/new-design/all.py
Outdated
| networking = ['none', 'bridge', 'nat', 'tap'] | ||
|
|
||
| def _convert_to_dict(i): | ||
| return { |
There was a problem hiding this comment.
Suggested change
| return { | |
| return { |
could you add an assert for the number of options, to make sure we get an error when we add a new option and we don't modify in all places
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Until this point a variant consisted of a combination of build and run parameters. However, this was redundant as the the build parameters (and build) were part of multiple variants. Separate build parameters from run parameters in `tester.yaml`. A variant consists of a build variant (set of parameters) and multiple run variants (an array of sets of parameters). Signed-off-by: Razvan Deaconescu <[email protected]>
Update templates for build commands to use Clang or GCC. Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Use the same name networking in the tester configuration file and in the template script names: "bridge", "nat", "tap". Signed-off-by: Razvan Deaconescu <[email protected]>
Add Firecracker template scripts and support in generating run scripts and configuration files (JSON). Signed-off-by: Razvan Deaconescu <[email protected]>
razvand
force-pushed
the
razvand/generator/new-design
branch
from
e2ce519
to
b8bd606
Compare
Add directory with common support scripts. Add `common.sh` script used for running tests. Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Add `xen` to Kraftfile. Add `config.yaml` with testing configurations. Add `.test` basic test script. Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
`.tests/` is the working directory for testing. Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new design for generator script