feat: Add Xen support #1240
Open
feat: Add Xen support #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreistan26
commented
Feb 21, 2024
Comment on lines
+67
to
+71
| for { | ||
| if peekAndRead(f, reader, &logs, &errs) { | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
We can get multi-line writes with one event triggered.
IMO something better would be for peekAndRead to look ahead for the last newline so we end up with a single write.
andreistan26
force-pushed
the
xen
branch
3 times, most recently
from
f32e678
to
9b5e55a
Compare
andreistan26
changed the title
xen support for kraftkitXen support
andreistan26
force-pushed
the
xen
branch
2 times, most recently
from
4726be4
to
c67465b
Compare
craciunoiuc
requested changes
Apr 16, 2024
andreistan26
force-pushed
the
xen
branch
2 times, most recently
from
cb8812c
to
96a6886
Compare
andreistan26
force-pushed
the
xen
branch
3 times, most recently
from
029891f
to
08c224c
Compare
craciunoiuc
requested changes
May 8, 2024
andreistan26
force-pushed
the
xen
branch
3 times, most recently
from
77bcc05
to
53b93b4
Compare
|
Hey @andreistan26 any new updates here? |
Will finish it up this week |
|
sure thing, no hurry, just wanted to get a status update |
Signed-off-by: Andrei Stan <[email protected]>
Signed-off-by: Andrei Stan <[email protected]>
andreistan26
force-pushed
the
xen
branch
2 times, most recently
from
6deb6e0
to
c9ecb1b
Compare
|
Can you also add this? thanks: diff --git a/Makefile b/Makefile
index 2b5d0ac0..18f88386 100644
--- a/Makefile
+++ b/Makefile
@@ -272,6 +272,7 @@ buildenv-myself-full: ## OCI image containing the build environment for KraftKit
buildenv-myself: ## OCI image containing KraftKit binaries.
buildenv-qemu: ## OCI image containing a Unikraft-centric build of QEMU.
buildenv-github-action: ## OCI image used when building Unikraft unikernels in GitHub Actions.
+buildenv-xen: ## OCI image containing a Unikraft-centric build of Xen.
tools: ## Build all tools.
kraft: ## The kraft binary.
runu: ## The runu binary. |
Signed-off-by: Andrei Stan <[email protected]>
In the case of Xen, on fast applications, the logs would have been called when the machine was already in the exit state. Signed-off-by: Andrei Stan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
GitHub-Closes: #990