Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ hoc / not found routes #34

Merged
merged 1 commit into from
Oct 12, 2018
Merged

✨ hoc / not found routes #34

merged 1 commit into from
Oct 12, 2018

Conversation

fabienjuif
Copy link
Member

related to #14

This is a first implementation of not found routes.
The next implementation (v2) should allow us to have multiple nested not found routes. This is quite necessary for conference-hall.

cc - @AFaugeras

@fabienjuif
Copy link
Member Author

@frinyvonnick is it something you are interested by ?

@fabienjuif
Copy link
Member Author

cc @bpetetot

Copy link
Member

@guillaumecrespel guillaumecrespel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@fabienjuif fabienjuif merged commit e6155e2 into master Oct 12, 2018
@fabienjuif fabienjuif deleted the notFound branch October 12, 2018 09:38
@AFaugeras
Copy link

Works like a charm, thanks! :)

@fabienjuif
Copy link
Member Author

You are welcome, feel free to ask questions in issues of our differents libs ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants