fix lags_past_covariates dict type breaks lags_future_covariates when output_chunk_shift>0 #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2655 +/- ##
==========================================
- Coverage 94.23% 94.18% -0.06%
==========================================
Files 141 141
Lines 15509 15510 +1
==========================================
- Hits 14615 14608 -7
- Misses 894 902 +8 ☔ View full report in Codecov by Sentry. |
…lags_future_covariates_when_output_chunk_shift
dennisbader
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Thanks for fixing this @authierj.
Would be good to add a unit test to cover this in the future :)
dennisbader
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Great job, thanks a lot @authierj. Also, congrats to your first contribution 🚀
authierj
deleted the
fix/lags_past_covariates_dict_type_breaks_lags_future_covariates_when_output_chunk_shift
branch
ymatzkevich
pushed a commit
to ymatzkevich/darts
that referenced
this pull request
Feb 6, 2025
… output_chunk_shift>0 (unit8co#2655) * if clause modified to correct bug * contribution added to changelog * implemented modifications from reviewer * unit tests added --------- Co-authored-by: “authierj” <“[email protected]”>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Fixes #2652
Summary
RegressionModelwithlags_past_covariatesas dict andlags_future_covariatesas some other type (not dict) andoutput_chunk_shift>0, an error occurred.lags_future_covariateis not a component lag and should therefore not be handled at any point byprocessed_component_lags.ifstatement in line 396 ofregression_model.pyfixes the bug.Other Information
None