Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python path if working locally #2691

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Conversation

authierj
Copy link
Contributor

@authierj authierj commented Feb 20, 2025

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #2690.

Summary

Added fix_pythonpath_if_working_locally() to the jupyter notebook.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.12%. Comparing base (cda8f81) to head (ae749d9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2691      +/-   ##
==========================================
- Coverage   94.20%   94.12%   -0.08%     
==========================================
  Files         141      141              
  Lines       15569    15569              
==========================================
- Hits        14666    14654      -12     
- Misses        903      915      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot @authierj 🚀

@dennisbader dennisbader merged commit 093230a into unit8co:master Feb 21, 2025
9 checks passed
@authierj authierj deleted the fix/quickstart branch February 21, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

00-quickstart.ipynb do not run locally
2 participants