Fix issue with OPCUA client disconnection #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Danelon <[email protected]>
JeremyTheocharis
requested changes
Dec 8, 2023
There was a problem hiding this comment.
Can you add a test related to this?
Also what do you mean with failing test? The last test run worked perfectly fine: https://github.com/united-manufacturing-hub/benthos-umh/actions/runs/7034288225/job/19141981561
|
Failing test is fixed in #26 I would not know how to test the change introduced by this PR, as I don't know how to simulate that type of disconnection |
JeremyTheocharis
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a failed read, in case of a
StatusBadServerNotConnectedOPC UA error, returning theservice.ErrNotConnectederror triggers a logic that continuously tries to reconnectFixes https://github.com/united-manufacturing-hub/MgmtIssues/issues/1163
Test "Connect Subscribe Scalar Arrays" was already failing before my changes