Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/xxx/ifm barcode nodered #82

Merged
merged 23 commits into from
Apr 28, 2023

Conversation

krgrsebastian
Copy link
Contributor

@krgrsebastian krgrsebastian commented Mar 14, 2023

Added retrofitting with ifm gateways, data connectivity with node-RED, and barcodereaders to the features section

@krgrsebastian krgrsebastian requested a review from a team March 14, 2023 13:00
@krgrsebastian krgrsebastian self-assigned this Mar 14, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8629a7e
Status: ✅  Deploy successful!
Preview URL: https://9acabb28.umh-docs-umh-app.pages.dev
Branch Preview URL: https://feat-xxx-ifm-barcode-nodered.umh-docs-umh-app.pages.dev

View logs

@krgrsebastian krgrsebastian marked this pull request as draft March 14, 2023 13:03
@krgrsebastian krgrsebastian marked this pull request as ready for review March 14, 2023 14:20
@JeremyTheocharis JeremyTheocharis changed the base branch from main to feat/xxx/features-section March 14, 2023 14:52
@CLAassistant
Copy link

CLAassistant commented Mar 22, 2023

CLA assistant check
All committers have signed the CLA.

change: first sentence, less repetitive
add: Step by Step instruction for the barcode reader
add:
-Step by Step instruction for sensorconnect
-Links to ifm and the retrofitting blog article
-info for analog and digital sensors
@DaruZero DaruZero self-requested a review April 25, 2023 08:50
Copy link
Contributor

@DaruZero DaruZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the new articles in page bundles if it only contains one .md file? Please convert to standalone pages.
From this

features/
├── barcodereader-retrofitting/
│   └── index.md
├── data-connectivity-node-red/
│   └── index.md
...

to this

features/
├── barcodereader-retrofitting.md
├── data-connectivity-node-red.md
...

Also. please use the correct formatting style.

  • Each line should not be longer than 80 characters. You can set a vertical line in your text editor to help you with that. Depending on the editor you use, the setting might be called ruler, right margin, or column
  • Use a markdown linter. For example, in VS code there is an extension called markdownlint that will show you common style errors, like not having a blank line before and after a code block ``` ... ```

Lastly, remember to squash the commits before merging. Here more info about that. Ask me for help if you have doubts


## When should I use it?

Sometimes it is necessary to connect a lot of different protocols (e.g Siemens-S7, OPC-UA, Serial, ...) and node-RED can be a maintainable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont get that point. I didnt use "We" _(.)_/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was talking about the "e.g", but it's too late now I guess

@JeremyTheocharis
Copy link
Member

Why are the new articles in page bundles if it only contains one .md file? Please convert to standalone pages. From this

features/
├── barcodereader-retrofitting/
│   └── index.m
├── data-connectivity-node-red/
│   └── index.md
...

to this

features/
├── barcodereader-retrofitting.md
├── data-connectivity-node-red.md
...

Because the original template from me had this structure as well. If we change that structure, we should either change all of the mand introduce redirects. Or we just leave it like this.

@DaruZero
Copy link
Contributor

Ok, then maybe in another PR we should change the structure, and maybe also add the archetype (already filed an issue for that #124)

@krgrsebastian krgrsebastian requested a review from DaruZero April 28, 2023 09:11
@krgrsebastian krgrsebastian merged commit ca005ac into feat/xxx/features-section Apr 28, 2023
JeremyTheocharis added a commit that referenced this pull request May 5, 2023
* feat: first draft of Unified Namespace

* feat: added historian

* added links to features

* added documentation for datasource v1 and v2

* added matteos and jeremys feedback

* shortcodes

* added analytics section

* finished

* fix: added Ferdinands feedback for limitations

* Feat/xxx/ifm barcode nodered (#82)

* Ifm-retrofitting

* Ifm-retrofitting

* Ifm-retrofitting

* Ifm-retrofitting

* Ifm-retrofitting

* Data connectivity with Node-RED

* #

* #

* barcodereader

* barcodereader

* barcodereader

* feedback jeremy

* feedback jeremy

* feedback jeremy

* fix: Corrected a few spelling mistakes
change: first sentence, less repetitive
add: Step by Step instruction for the barcode reader

* fix: Corrected a few spelling mistakes, rephrased stuff etc.
add:
-Step by Step instruction for sensorconnect
-Links to ifm and the retrofitting blog article
-info for analog and digital sensors

* add: Link to the community repo

* fix: spelling

* fix: spelling

* included Matteos Feedback

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: David Mackel <[email protected]>

* feat: finishing touches

---------

Co-authored-by: krgrsebastian <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: krgrsebastian <[email protected]>
Co-authored-by: David Mackel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants