Remove all document.querySelector('.SiteLayout__main').innerHTML hacks.

[DrMeers]

I initially tried submitting #2464 for Hickenlooper but this was rejected.

I think if such a wholesale hack as replacing the entire HTML of the form is required, there are some deeper issues that should be investigated/resolved. I think this almost defeats the purpose of having step-by-step form filling YAML, at that point you could basically submit a custom payload to the server using a single javascript command rather than creating an arbitrary form and filling it out. These hacks are causing all kinds of trouble on our end including ReCAPTCHA failures.

I'm happy to help find the actual problems that these form-rewrite hacks have been instated to resolve, though so far I've found that each of these forms I've tested is succeeding if you remove the innerHTML javascript. Please share details of what problems are encountered for others if these lines are removed, and maybe we can figure out a more elegant/robust solution.

[j-ro]

Unfortunately can't accept this -- it's required by the phantom system we use, which is the original (and at this point sole) point of this repo. Feel free to fork though!

[DrMeers]

are you happy to share what problems are you seeing if you remove these lines?

We're OK if not, and can just not collaborate on any of these ten members going forward (and any others that have this method applied to them in future), but seems a shame

[j-ro]

We get failures when we try to fill them out. I don't have errors in front of me, but I'm sure they're specific to the phantom versions we're running, so not sure that's super fruitful to discuss unless you want to mimic our setup.

[DrMeers]

No worries, I'll detach our system from these ten members and try to keep an eye out for any document.querySelector('.SiteLayout__main').innerHTML updates in future and detach from those as well. Feel free to reach out if things change and you'd like help maintaining the YAML for these