fix: add empty transforms to the list of objects for making instances #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chy with empty transforms.
sindharta-tanuwijaya
changed the title
sindharta-tanuwijaya
changed the title
sindharta-tanuwijaya
changed the title
sindharta-tanuwijaya
added a commit
that referenced
this pull request
Apr 6, 2023
…#903) (#906) * Ensure parent objects are added when an object is created in a hierarchy with empty transforms. * Fix for compiler error in yamato * Refactoring to make the code more complicated * Using existing method instead of new one (cherry picked from commit 81304e7) Co-authored-by: schinkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with files that use empty transforms as instances. Those empty transforms were not added to the list of client objects and would not be accessible when needed to make instances.
This change fixes that.
Need to merge this #901 first.