feat: render heading support restricted level #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Sep 12, 2024
src/render.ts
Outdated
| @@ -14,6 +14,7 @@ | |||
| * @group render_utils | |||
| */ | |||
| export function heading(text: string, level: number): string { | |||
There was a problem hiding this comment.
Maybe we should restrict the type for level as well?
There was a problem hiding this comment.
I mean
Suggested change
| export function heading(text: string, level: number): string { | |
| export function heading(text: string, level: 1|2|3|4|5|6): string { |
There was a problem hiding this comment.
I won't pin all my hopes on typescript, I will if you want.
There was a problem hiding this comment.
we can also use |(number & {}) to make your life better? :p
There was a problem hiding this comment.
I still want to use the number type and handle the level inside the function, So that it can be called recursively without error.
pi0
reviewed
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.