feat: return font file priority #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
Feb 21, 2025
danielroe
reviewed
Feb 21, 2025
Comment on lines
+79
to
83
| data.map((f) => { | ||
| f.meta ??= {} | ||
| f.meta.priority = priority | ||
| return f | ||
| }) |
There was a problem hiding this comment.
I think we should have some logic to decide about increasing priority
- 1st request: woff2
- 2nd request: some woff2 and woff
(because naturally browser will follow priority vs extensions if in the same font-face declaration)
There was a problem hiding this comment.
Yes, that's exactly what I'm thinking about. Should we do it directly in unifont or in Nuxt Fonts?
Co-authored-by: Daniel Roe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From nuxt/fonts#508.
This PR adds an additional
meta.prioritytoFontFaceDatato indicate fallback files.