Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix body scroll bug #1205

Merged
merged 4 commits into from
Nov 28, 2018
Merged

Fix body scroll bug #1205

merged 4 commits into from
Nov 28, 2018

Conversation

jsturek
Copy link
Contributor

@jsturek jsturek commented Nov 15, 2018

Fix body scroll bug with desktop nav closing without clicking close and resizing between mobile and desktop.

To test:

  • In desktop verify that when nav is open and nav closes without clicking it closed, that the body scroll is not locked.
  • Verify that moving between desktop and mobile with nav open that nav and body scroll behave correctly.
  • Verify that moving between mobile and desktop with nav open that nav and body scroll behave correctly.
  • Verify that moving between desktop and mobile with nav closed that nav and body scroll behave correctly.
  • Verify that moving between mobile and desktop with nav closed that nav and body scroll behave correctly.

@jsturek jsturek changed the base branch from 5.0 to develop November 20, 2018 21:42
@skoolbus39
Copy link
Member

We discovered another bug (#1215) effecting mega menu states, but it shouldn't hold up merging this fix.

@skoolbus39 skoolbus39 merged commit 1c405c5 into unl:develop Nov 28, 2018
@jsturek jsturek deleted the desktop-scroll-bug branch November 28, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants