chore: Update googletest dependency #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The googletest dependency was using an older version from the WPILib Artifactory, this was causing issues with builds on macOS where `osxuniversal` platform type was not available, and split between `osxarm64` and `osxx86-64`. Added a testing workflow as the normal build workflow was skipping tests.
Test workflow requires actively connected hardware for the tests to pass. This workflow has been deleted until a way to simulate the hardware can be discovered.
garrettsummerfi3ld
changed the title
|
Might want to re-write the commit history on this branch before merging. Or just make a new commit directly on |
|
I re-worked the commit and pushed it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The googletest dependency was using an older version from the WPILib Artifactory, this was causing issues with builds on macOS where
osxuniversalbeing the default platform type was not available, and split betweenosxarm64andosxx86-64. This would cause googletest to fail the download and would fail the rest of the building/testing.Added a testing workflow as the normal build workflow was skipping tests.Tests require actively connected hardware to pass, these tests have been removed.