chore: Mark SystemThemeHelper methods as obsolete #1324
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1324.eastus2.azurestaticapps.net |
There was a problem hiding this comment.
@morning4coffe-dev I believe we actually don't have docs right now for SystemThemeHelper. We should add it, probably better to be in a separate PR
| @@ -34,6 +31,7 @@ public static ApplicationTheme GetCurrentOsTheme() | |||
| /// <summary> | |||
| /// Get the current theme of the application. | |||
| /// </summary> | |||
| [EditorBrowsable(EditorBrowsableState.Never)] | |||
There was a problem hiding this comment.
We should also add the attribute to ToggleApplicationTheme method as well, right? Since itself is referencing the deprecated methods?
There was a problem hiding this comment.
Done. Docs page added via #1330
There was a problem hiding this comment.
This one is still using EditorBrowsable and not Obsolete. Was there are reason?
| @@ -54,12 +52,14 @@ public static ApplicationTheme GetRootTheme(XamlRoot? root) | |||
| /// <summary> | |||
| /// Get if the application is currently in dark mode. | |||
| /// </summary> | |||
| [EditorBrowsable(EditorBrowsableState.Never)] | |||
There was a problem hiding this comment.
I'm leaning more toward using the ObsoleteAttribute
There was a problem hiding this comment.
We were discussing this with Martin as well. I think it makes sense.
morning4coffe-dev
changed the title
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1324.eastus2.azurestaticapps.net |
GitHub Issue (If applicable): part of unoplatform/uno#19235
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):