Merge pull request #663 from nventive/dev/mafi/stable-z-vs15.9-compat…

…ibility Add missing analyzer for VS15.9 compatibility
unoplatform · Mar 8, 2019 · 2ee6e1f · 2ee6e1f
2 parents ec61215 + 7acb7d9
commit 2ee6e1f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/gitversion.yml b/gitversion.yml
@@ -1,6 +1,6 @@
 assembly-versioning-scheme: MajorMinorPatch
 mode: ContinuousDeployment
-next-version: 1.43.0
+next-version: 1.43.1
 continuous-delivery-fallback-tag: ""
 branches:
   master:

diff --git a/src/SourceGenerators/System.Xaml/System.Xaml/XamlType.cs b/src/SourceGenerators/System.Xaml/System.Xaml/XamlType.cs
@@ -467,7 +467,7 @@ IEnumerable<XamlMember> DoLookupAllMembers ()
 			var bf = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance;
 
 			foreach (var pi in UnderlyingType.GetProperties (bf)) {
-				if (pi.Name.Contains ('.')) // exclude explicit interface implementations.
+				if (pi.Name.Contains (".")) // exclude explicit interface implementations.
 					continue;
 				if (pi.CanRead && (pi.CanWrite || IsCollectionType (pi.PropertyType) || typeof (IXmlSerializable).IsAssignableFrom (pi.PropertyType)) && pi.GetIndexParameters ().Length == 0)
 					yield return new XamlMember (pi, SchemaContext);

diff --git a/src/Uno.MonoAnalyzers/MonoNotSupportedAPIAnalyzer.cs b/src/Uno.MonoAnalyzers/MonoNotSupportedAPIAnalyzer.cs
@@ -76,6 +76,7 @@ public Container(Compilation compilation, MonoNotSupportedAPIAnalyzer owner)
 							"IndexOfAny",
 							"Join",
 							"StartsWith",
+							"Contains",
 						},
 						Validation = new Func<IMethodSymbol, bool>(
 							m => m.Parameters.FirstOrDefault()?.Type == _charSymbol