Skip to content

Commit

Permalink
chore: Fix transitive assets support
Browse files Browse the repository at this point in the history
  • Loading branch information
jeromelaban committed Sep 17, 2024
1 parent 6c698d8 commit d93c4cd
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@
<PackageReference Update="Uno.Core.Extensions.Disposables" Version="4.0.1" />
<PackageReference Update="Uno.Core.Extensions.Compatibility" Version="4.0.1" />
<PackageReference Update="Uno.Diagnostics.Eventing" Version="2.0.1" />
<PackageReference Update="Uno.Wasm.Bootstrap" Version="9.0.0-dev.284" />
<PackageReference Update="Uno.Wasm.Bootstrap.DevServer" Version="9.0.0-dev.284" />
<PackageReference Update="Uno.Wasm.Bootstrap" Version="9.0.0-dev.286" />
<PackageReference Update="Uno.Wasm.Bootstrap.DevServer" Version="9.0.0-dev.286" />
<PackageReference Update="MSTest" Version="3.3.1" />
<PackageReference Update="MSTest.TestFramework" Version="3.3.1" />
<PackageReference Update="MSTest.TestAdapter" Version="3.3.1" />
Expand Down
3 changes: 3 additions & 0 deletions src/SamplesApp/SamplesApp.Wasm/SamplesApp.Wasm.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@

<PublishTrimmed>false</PublishTrimmed>

<!-- Include all satellite assemblies -->
<WasmShellLoadAllSatelliteResources>true</WasmShellLoadAllSatelliteResources>

<!--
IL Linking is disabled in Debug configuration.
When building in Release, see https://platform.uno/docs/articles/features/using-il-linker-webassembly.html
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions src/SamplesApp/UITests.Shared/UITests.Shared.projitems
Original file line number Diff line number Diff line change
Expand Up @@ -9617,6 +9617,7 @@
<Content Include="$(MSBuildThisFileDirectory)Assets\closeIcon.png" />
<Content Include="$(MSBuildThisFileDirectory)Assets\colored-ellipse.jpg" />
<Content Include="$(MSBuildThisFileDirectory)Assets\ColorPicker.png" />
<None Include="$(MSBuildThisFileDirectory)Assets\colors300-transitive.png" />
<Content Include="$(MSBuildThisFileDirectory)Assets\colors300.png" />
<Content Include="$(MSBuildThisFileDirectory)Assets\ComboBox.png" />
<Content Include="$(MSBuildThisFileDirectory)Assets\CommandBarFlyout.png" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,8 @@
<Link>wwwroot/%(TargetPath)</Link>
<TargetPath></TargetPath>
</_UnoTransitiveItems>
<_UnoTransitiveItems Remove="@(StaticWebAsset)" />

<_UnoTransitiveItems Remove="@(StaticWebAsset)" Condition="'%(StaticWebAsset.Link)' == '%(_UnoTransitiveItems.Link)'" />
</ItemGroup>

<DefineStaticWebAssets
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,12 @@ internal static class InternalCalls
{
// Uno-Specific implementation for https://github.com/dotnet/runtime/issues/69409.
// To be removed when the runtime will support the main SynchronizationContext.
[MethodImplAttribute(MethodImplOptions.InternalCall)]
public static extern void InvokeOnMainThread();
// [MethodImplAttribute(MethodImplOptions.InternalCall)]
public static void InvokeOnMainThread()
{
Console.WriteLine("invoking InvokeOnMainThread");
throw new Exception("InvokeOnMainThread not supported");
}
}
}
}
2 changes: 1 addition & 1 deletion src/Uno.UI.RuntimeTests/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.targets', '$(MSBuildThisFileDirectory)../'))" />

<ItemGroup>
<Content Include="$(MSBuildThisFileDirectory)..\SamplesApp\UITests.Shared\Assets\colors300.png" Link="Assets\TransitiveTest\colors300.png" />
<Content Include="$(MSBuildThisFileDirectory)..\SamplesApp\UITests.Shared\Assets\colors300-transitive.png" Link="Assets\TransitiveTest\colors300.png" />
</ItemGroup>

<!--
Expand Down

0 comments on commit d93c4cd

Please sign in to comment.