Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gallery][Wasm/Android/iOS]MediaPlayerElement(First sample option)- when first click 'Full screen' and then click 'Enter Mini view' option then both option gets disappear. #13272

Merged
merged 2 commits into from
Aug 17, 2023
Merged

[Gallery][Wasm/Android/iOS]MediaPlayerElement(First sample option)- when first click 'Full screen' and then click 'Enter Mini view' option then both option gets disappear. #13272

merged 2 commits into from
Aug 17, 2023

Conversation

rafael-rosa-knowcode
Copy link
Contributor

@rafael-rosa-knowcode rafael-rosa-knowcode commented Aug 16, 2023 •
edited
Loading

GitHub Issue (If applicable): closes #12696
closes #12660
closes #12659

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

image

What is the new behavior?

The correct space and options.

Copilot Summary

🤖 Generated by Copilot at e4bae18

This pull request enhances the MediaPlayerElement and its MediaTransportControls in Uno Platform. It fixes a typo, improves the full-screen mode, and refines the layout logic and appearance of the command bar and its buttons. It also addresses some potential bugs and performance issues.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@nventive-devops
Copy link
Contributor

The build 90077 found UI Test snapshots differences: android-28-net7: 0, android-28-net7-Snap: 641, ios: 32, ios-Snap: 113, skia-gtk-screenshots: 18, skia-wpf-screenshots: 16, wasm: 37, wasm-automated-net7.0-UWP-Benchmarks: 0, wasm-automated-net7.0-UWP-Default: 34, wasm-automated-net7.0-UWP-RuntimeTests: 0, wasm-automated-net7.0-WinUI-RuntimeTests: 0

Details

  • android-28-net7: 0 changed over 1

  • android-28-net7-Snap: 641 changed over 1043

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_Fill_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_Fill
    • Border_AutoBorderStretchwithrightmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithrightmargin
    • Border_Border_Simple_with_non_Uniform_Thickness_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_with_non_Uniform_Thickness
    • Border_Uniform_Thickness_and_Large_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Uniform_Thickness_and_Large_Radius
    • Brushes_ImageBrushStretch2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch2
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
    • Buttons_RadioButton_Combined_Style_UITests_Shared_Windows_UI_Xaml_Controls_Button_RadioButton_Combined_Style
    • CheckBox_UITests_Shared_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_Automated_UITests_Shared_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_Automated
    • Clipping_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingToControlBounds_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingToControlBounds
    • Clipping_UITests_Windows_UI_Xaml_Clipping_Clipping652_UITests_Windows_UI_Xaml_Clipping_Clipping652
    • ContentControl_ContentControl_NoTemplateDataContext_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_NoTemplateDataContext
    • ContentControl_ContentControl_NoTemplateNoContent_SamplesApp_Windows_UI_Xaml_Controls_ContentControlNoTemplateNoContent
    • Default_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure
    • Default_UITests_Shared_Windows_UI_Xaml_Controls_Popup_Popup_Overlay_On_UITests_Shared_Windows_UI_Xaml_Controls_Popup_Popup_Overlay_On
    • Expander_Expander_ScrollView_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_Expander_ScrollView
    • Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
    • Gesture_Recognizer_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_GestureEventsCommons_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_GestureEventsCommons
    • Gesture_Recognizer_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_HoldingTests_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_HoldingTests
    • Grid_Grid_Two_bottom_row_Auto_middle_col_auto_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_Two_bottom_row_Auto_middle_col_auto
    • Grid_Grid_with_attributed_string_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_attributed_string

  • ios: 32 changed over 270

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Screenshots_Image_Stretch_Alignment_Taller_Mode-2
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • XamlCommandBar_Automated_AfterPlay
    • XamlCommandBar_Automated_AfterShuffle
    • Check_CornerRadius_Border_No_CornerRadius
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-1
    • Screenshots_Image_Stretch_Alignment_Wider_Mode-2
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • TextBox_Foreground_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_Foreground
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-0
    • ScrollViewer_WhenSync_RunNormalAndCompletesWithNonIntermediate_UITests_Shared_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_UpdatesMode
    • When_Visibility_Changed_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Visibility_Arrange
    • XamlCommandBar_Automated_Initial
    • XamlCommandBar_Automated_UITests_Shared_Windows_UI_Xaml_Controls_CommandBar_CommandBar_Xaml_Automated
    • Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
    • Check_CornerRadius_Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Toggle
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings

  • ios-Snap: 113 changed over 1034

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Buttons_AppBarButtonTest_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBarButtonTest
    • Buttons_Hyperlink_Disabled_nVentive_Umbrella_Views_UI_Samples_Content_UITests_ButtonTestsControl_Hyperlink_Disabled
    • ComboBox_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Description_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Description
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl
    • Pickers_UITests_Windows_UI_Xaml_Controls_DatePicker_DatePicker_VisualStates_UITests_Windows_UI_Xaml_Controls_DatePicker_DatePicker_VisualStates
    • TextBlock_Attributed_text_Supserscript_Uno_UI_Samples_Content_UITests_TextBlockControl_Attributed_text_Supserscript
    • Buttons_UITests_Windows_UI_Xaml_Controls_RadioButtonTests_RadioButton2450_UITests_Windows_UI_Xaml_Controls_RadioButtonTests_RadioButton2450
    • ComboBox_ComboBox_ItemDataContext_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ItemDataContext
    • CommandBar_CommandBar_Xaml_Automated_UITests_Shared_Windows_UI_Xaml_Controls_CommandBar_CommandBar_Xaml_Automated
    • ListView_ListViewHeaderUpdate_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderUpdate
    • Path_PathVerticalOffsetAdjustable_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_PathVerticalOffsetAdjustable
    • ContentControl_ContentControl_Inheritance_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Inheritance
    • Gesture_Recognizer_UITests_Windows_UI_Input_GestureRecognizerTests_Manipulation_Inertia_UITests_Windows_UI_Input_GestureRecognizerTests_Manipulation_Inertia
    • ListView_UITests_Windows_UI_Xaml_Controls_ListView_ListView_DuplicateItem_UITests_Windows_UI_Xaml_Controls_ListView_ListView_DuplicateItem
    • LoopingSelector_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Items_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Items
    • NumberBox_UITests_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBox_Description_UITests_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBox_Description
    • Path_Path_With_DashStrokeArray_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_Path_With_DashStrokeArray
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping
    • ListView_HorizontalListViewImage_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewImage
    • ListView_ListView_Changing_Text_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text

  • skia-gtk-screenshots: 18 changed over 1117

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView-ListViewSelectedItems.png
    • DragAndDrop-DragDrop_TestPage.png
    • MUX-NavigationViewRS4Page.png
    • Brushes-ImageBrushChangingCornerRadius.png
    • MediaPlayerElement-MediaPlayerElement_Stretch_Fill.png
    • MediaPlayerElement-Mini player.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Transform-TransformToVisual_Translate2d.png
    • NavigationView-NavigationViewRS4Page.png
    • Progress-ProgressRingHeightTest.png
    • Progress-WindowsProgressRing_GH1220.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Image-Image_Stretch.png
    • WinUI-PipsPagerExamples.png
    • PipsPager-PipsPagerExamples.png

  • skia-wpf-screenshots: 16 changed over 1117

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Image-ImageSourceStream.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Automation-AutomationProperties_Name.png
    • Progress-ProgressRingHeightTest.png
    • ListView-ListViewSelectedItems.png
    • TabView-TabViewPage.png
    • MUX-TabViewPage.png
    • PipsPager-PipsPagerExamples.png
    • Progress-WindowsProgressRing_GH1220.png
    • Transform-TransformToVisual_Translate2d.png
    • Image-UniformToFill100x100.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • WinUI-PipsPagerExamples.png

  • wasm: 37 changed over 1040

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.NavigationViewTopNavOnlyPage
    • UITests.Windows_Media.MediaPlayerTests
    • initial_state
    • UITests.Windows_UI_Xaml_Controls.LoopingSelectorTests.LoopingSelector_Short
    • UITests.Windows_UI_Xaml_Controls.ScrollViewerTests.ScrollViewer_SnapPoints
    • UITests.Windows_UI_Xaml_Shapes.LineStretchModes
    • MUXControlsTestApp.PipsPagerPage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.ProgressRingHeightTest
    • UITests.Windows_UI_Xaml.UIElementTests.UIElement_InitializationSequence
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220
    • UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mp3_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Ogg_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Stretch_Fill
    • Uno.UI.Samples.Samples.Shared.Content.UITests.ImageBrushInList
    • MUXControlsTestApp.NavigationViewAnimationPage
    • MUXControlsTestApp.NavigationViewMinimalPage
    • MUXControlsTestApp.PipsPagerExamples
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected

  • wasm-automated-net7.0-UWP-Benchmarks: 0 changed over 1

  • wasm-automated-net7.0-UWP-Default: 34 changed over 1923

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • MediaPlayerElement_Using_avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
    • MediaPlayerElement_Using_flv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Flv_Extension
    • MediaPlayerElement_Using_mkv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mkv_Extension
    • MediaPlayerElement_Using_mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • DatePicker_Flyout_DatePicker_-_Flyout
    • MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • BasicTest_UITests_Shared_Microsoft_UI_Xaml_Controls_RadioMenuFlyoutItemTests_RadioMenuFlyoutItemPage
    • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
    • ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers

  • wasm-automated-net7.0-UWP-RuntimeTests: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests: 0 changed over 1

@jeromelaban jeromelaban enabled auto-merge August 16, 2023 16:04
@agneszitte agneszitte linked an issue Aug 16, 2023 that may be closed by this pull request
[Gallery][iOS/Android][MediaPlayerElement] For the 'Sample using a playlist' option when click Full screen option and close the mobile and reopen it, gallery app getting freeze. #12659
Open
@rafael-rosa-knowcode rafael-rosa-knowcode mentioned this pull request Aug 16, 2023
Open
@nventive-devops
Copy link
Contributor

The build 90150 found UI Test snapshots differences: android-28-net7: 0, android-28-net7-Snap: 67, ios: 34, ios-Snap: 119, skia-gtk-screenshots: 18, skia-wpf-screenshots: 16, wasm: 49, wasm-automated-net7.0-UWP-Benchmarks: 0, wasm-automated-net7.0-UWP-Default: 33, wasm-automated-net7.0-UWP-RuntimeTests: 0, wasm-automated-net7.0-WinUI-RuntimeTests: 0

Details

  • android-28-net7: 0 changed over 1

  • android-28-net7-Snap: 67 changed over 1043

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • BreadcrumbBar_MUXControlsTestApp_BreadcrumbBarPage_MUXControlsTestApp_BreadcrumbBarPage
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ListView_ListViewSnapPointsMandatorySingle_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSnapPointsMandatorySingle
    • TextBlock_TextBlock_LineHeight_Multiline_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_Multiline
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl
    • ListView_ListViewStackPanel_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewStackPanel
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • ListView_ListViewHeaderImage_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderImage
    • MediaPlayerElement_Using_avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
    • MediaPlayerElement_Using_flv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Flv_Extension
    • Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • GridView_Uno_UI_Samples_Content_UITests_GridView_GridView_Inside_ScrollViewer_Uno_UI_Samples_Content_UITests_GridView_GridView_Inside_ScrollViewer
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
    • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
    • Transform_Border_With_TranslateTransform_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_Border_With_TranslateTransform
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected

  • ios: 34 changed over 270

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • ScrollViewer_WhenAsync_RunIdleAndCompletesWithNonIntermediate_UITests_Shared_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_UpdatesMode
    • TextBox_Foreground_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_Foreground
    • ComboBoxTests_ToggleDisabled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ToggleDisabled
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • ListView_ObservableCollection_Creation_Count_Scrolled2
    • Screenshots_Image_Stretch_Algmnt_Inf_Vertical_Mode-1
    • Screenshots_Image_Stretch_Algmnt_Inf_Vertical_Mode-2
    • Screenshots_Image_Stretch_Alignment_Wider_Mode-2
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • ComboBoxTests_ToggleDisabled_ComboBox_Disabled
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • XamlCommandBar_Automated_AfterClickMe
    • XamlCommandBar_Automated_AfterPlay
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ComboBoxTests_ToggleDisabled_ComboBox_Enabled
    • ListView_ChangingText_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text
    • Screenshots_Image_Stretch_Alignment_Wider_Mode-1
    • XamlCommandBar_Automated_UITests_Shared_Windows_UI_Xaml_Controls_CommandBar_CommandBar_Xaml_Automated
    • ListView_ObservableCollection_Creation_Count_Removed_above

  • ios-Snap: 119 changed over 1034

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Animations_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPage_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPage
    • Brushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
    • Buttons_AppBarToggleButtonTest_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBarToggleButtonTest
    • ContentControl_ContentControl_SetNull_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_SetNull
    • Default_UITests_Toolkit_ElevatedView_Tester_UITests_Toolkit_ElevatedView_Tester
    • LoopingSelector_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Items_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Items
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • Buttons_AppBarButtonTest_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBarButtonTest
    • ComboBox_ComboBox_Picker_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Picker
    • Flyouts_UITests_Windows_UI_Xaml_Controls_FlyoutTests_Flyout_ShowAt_Window_Content_UITests_Windows_UI_Xaml_Controls_FlyoutTests_Flyout_ShowAt_Window_Content
    • ListView_ListViewGroupedEmpty_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGroupedEmpty
    • Path_AutoSizedPathCentered_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_AutoSizedPathCentered
    • Focus_UITests_Windows_UI_Xaml_FocusTests_Focus_VisualStates_UITests_Windows_UI_Xaml_FocusTests_Focus_VisualStates
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • Border_BorderLeftwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderLeftwithmargins
    • Brushes_UITests_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_Formats_UITests_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_Formats
    • Buttons_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsFocusPage_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsFocusPage
    • CommandBar_CommandBar_CustomContent_UITests_Windows_UI_Xaml_Controls_CommandBar_CustomContent_CommandBar_Frame
    • NumberBox_UITests_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBox_Description_UITests_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBox_Description

  • skia-gtk-screenshots: 18 changed over 1117

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • PipsPager-PipsPagerExamples.png
    • Automation-AutomationProperties_Name.png
    • ListView-ListViewSelectedItems.png
    • Image-UniformToFill100x100.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • DragAndDrop-DragDrop_TestPage.png
    • MediaPlayerElement-Using .avi.png
    • MediaPlayerElement-MediaPlayerElement_Stretch_Fill.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • NavigationView-NavigationViewRS4Page.png
    • Progress-ProgressRingHeightTest.png
    • Transform-TransformToVisual_Translate2d.png
    • Progress-WindowsProgressRing_GH1220.png
    • TabView-TabViewPage.png
    • WinUI-PipsPagerExamples.png

  • skia-wpf-screenshots: 16 changed over 1117

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Image-ImageSourceStream.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • ListView-ListViewSelectedItems.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WindowsProgressRing_GH1220.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • DragAndDrop-DragDrop_TestPage.png
    • Progress-ProgressRingHeightTest.png
    • MUX-TabViewPage.png
    • Image-UniformToFill100x100.png
    • PipsPager-PipsPagerExamples.png
    • TabView-TabViewPage.png
    • WinUI-PipsPagerExamples.png
    • Transform-TransformToVisual_Translate2d.png

  • wasm: 49 changed over 1040

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • SamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_BasicNavigation
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.ProgressRingHeightTest
    • MUXControlsTestApp.PipsPagerExamples
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRingPage
    • MUXControlsTestApp.NavigationViewMenuItemStretchPage
    • MUXControlsTestApp.PaneLayoutTestPage
    • SamplesApp.Samples.NavigationViewSample.NavigationViewSample
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLargeHeader
    • UITests.Microsoft_UI_Xaml_Controls.NavigationViewTests.NavigationViewBasicPage
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_Explicit_Items
    • UITests.Windows_Media.MediaPlayerTests
    • SamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_Pane_Automated
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderImage
    • MUXControlsTestApp.SwipeControlPage2
    • SamplesApp.Samples.Microsoft_UI_Xaml_Controls.NavigationViewTests.FluentStyle.FluentStyle_NavigationViewSample
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
    • MUXControlsTestApp.NavigationViewBlankPage1
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_3gp_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Avi_Extension
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220

  • wasm-automated-net7.0-UWP-Benchmarks: 0 changed over 1

  • wasm-automated-net7.0-UWP-Default: 33 changed over 1923

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • LoopingSelector_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Short_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Short
    • DatePicker_Flyout_DatePicker_-_Flyout
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • BasicTest_UITests_Shared_Microsoft_UI_Xaml_Controls_RadioMenuFlyoutItemTests_RadioMenuFlyoutItemPage
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_ProgressRingHeightTest_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_ProgressRingHeightTest
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
    • MediaPlayerElement_Using_mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage

  • wasm-automated-net7.0-UWP-RuntimeTests: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests: 0 changed over 1

@jeromelaban jeromelaban merged commit 25739dc into master Aug 17, 2023
@jeromelaban jeromelaban deleted the dev/ramr/issue12696 branch August 17, 2023 00:15
@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/4x

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2023 •
edited
Loading

backport legacy/4x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte approved these changes

@Robert-Louis Robert-Louis Robert-Louis approved these changes

@jeromelaban jeromelaban jeromelaban approved these changes

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

@nickrandolph nickrandolph Awaiting requested review from nickrandolph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@rafael-rosa-knowcode @nventive-devops @agneszitte @jeromelaban @Robert-Louis @RafaelMendesRosa